Skip to content

fix: Don't prevent apply from running given duplicate empty names in data sources. Also fix repeated apply of Spark data source. #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 15 commits into from
Mar 29, 2022
Merged

fix: Don't prevent apply from running given duplicate empty names in data sources. Also fix repeated apply of Spark data source. #2415

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2db0c9a
fix: Print more warning statements on requirement for data sources to…
adchia Mar 17, 2022
2d4fc84
typo
adchia Mar 17, 2022
88a7434
typo
adchia Mar 17, 2022
ba97190
fix
adchia Mar 17, 2022
cdee46c
fix
adchia Mar 17, 2022
3a4b4cd
fix
adchia Mar 17, 2022
7add51a
More tests
adchia Mar 21, 2022
bc9d3ae
fix
adchia Mar 29, 2022
9d2c5f1
fix
adchia Mar 29, 2022
bae2e37
fix
adchia Mar 29, 2022
41ff4d9
fix
adchia Mar 29, 2022
70d4b8d
revert
adchia Mar 29, 2022
e17973f
fix
adchia Mar 29, 2022
0fe2df8
fix
adchia Mar 29, 2022
f854de4
fix
adchia Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Mar 29, 2022
commit e17973f8cefd82ed5d35ca424dae6cef55a8b25a
4 changes: 2 additions & 2 deletions sdk/python/tests/integration/registration/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ def test_universal_cli(environment: Environment):
cwd=repo_path,
)
assertpy.assert_that(result.returncode).is_equal_to(0)
assertpy.assert_that(fs.list_feature_views()).is_length(3)
assertpy.assert_that(fs.list_feature_views()).is_length(4)
result = runner.run(
["data-sources", "describe", "customer_profile_source"], cwd=repo_path,
)
assertpy.assert_that(result.returncode).is_equal_to(0)
assertpy.assert_that(fs.list_data_sources()).is_length(3)
assertpy.assert_that(fs.list_data_sources()).is_length(5)

# entity & feature view describe commands should fail when objects don't exist
result = runner.run(["entities", "describe", "foo"], cwd=repo_path)
Expand Down