Skip to content

fix: Create SparkSource inside try catch #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aurobindoc wants to merge 1 commit into from
Closed

fix: Create SparkSource inside try catch #2408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
create SparkSource inside try catch 
Signed-off-by: aurobindoc <aurobindoc1991@gmail.com>
  • Loading branch information
@aurobindoc
aurobindoc committed Mar 15, 2022
commit 349655dbb6f6438e57ed5b8e898566221fb0e194
9 changes: 8 additions & 1 deletion sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,14 @@ def from_proto(data_source: DataSourceProto) -> Any:
):
data_source_obj = KinesisSource.from_proto(data_source)
else:
raise ValueError("Could not identify the source type being added.")
try:
from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import (
SparkSource,
)

data_source_obj = SparkSource.from_proto(data_source)
except Exception:
raise ValueError("Could not identify the source type being added.")

return data_source_obj

Expand Down