Skip to content

feat: Postgres supported as Registry, Online store, and Offline store #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 24 commits into from
Apr 20, 2022
Merged

feat: Postgres supported as Registry, Online store, and Offline store #2401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ed18f7e
Feast-postgres added to Feast repo
nossrannug Mar 13, 2022
bc8a630
Add a template for postgres to allow feast init -t postgres
nossrannug Mar 20, 2022
1a705e3
Split contrib repo configuration to separate file for each
nossrannug Mar 20, 2022
643f911
Moved the postgres type maps into feast.type_map
nossrannug Mar 22, 2022
15e71e7
Upgrade to latest feast, get postgres tests running, pip lock files
nossrannug Apr 19, 2022
953c3e7
Fix setup.py
kevjumba Apr 20, 2022
66c4699
Fix the ci requirements
kevjumba Apr 20, 2022
d0b5081
Fix repo_config for rest of sources
kevjumba Apr 20, 2022
c4de36e
Make backwards compatible with python 3.8-
kevjumba Apr 20, 2022
979e326
Fix
kevjumba Apr 20, 2022
199850e
Fix
kevjumba Apr 20, 2022
885d789
address comments
adchia Apr 20, 2022
ad947a9
update lock files
adchia Apr 20, 2022
1f246ad
fix
adchia Apr 20, 2022
f625910
lock files
adchia Apr 20, 2022
c6d93cd
fix
adchia Apr 20, 2022
e6c39ff
cleanup
adchia Apr 20, 2022
caad6c0
missed refactor name
adchia Apr 20, 2022
a0f9476
Remove snowflake references from test.py for postgres
nossrannug Apr 20, 2022
7a792a5
update repo to match new API
adchia Apr 20, 2022
8e1509d
Add documentation
adchia Apr 20, 2022
8e6ec1e
rename utils
adchia Apr 20, 2022
3522e23
update roadmap docs
adchia Apr 20, 2022
72e9e3e
update documentation
adchia Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename utils 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Apr 20, 2022
commit 8e6ec1ea6052eb2f040339afa867ba6dec9fa69e
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
RetrievalJob,
RetrievalMetadata,
)
from feast.infra.utils.postgres.postgres_config import PostgreSQLConfig
from feast.infra.utils.postgres.utils import (
from feast.infra.utils.postgres.connection_utils import (
_get_conn,
df_to_postgres_table,
get_query_schema,
)
from feast.infra.utils.postgres.postgres_config import PostgreSQLConfig
from feast.on_demand_feature_view import OnDemandFeatureView
from feast.registry import Registry
from feast.repo_config import RepoConfig
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Callable, Dict, Iterable, Optional, Tuple

from feast.data_source import DataSource
from feast.infra.utils.postgres.utils import _get_conn
from feast.infra.utils.postgres.connection_utils import _get_conn
from feast.protos.feast.core.DataSource_pb2 import DataSource as DataSourceProto
from feast.repo_config import RepoConfig
from feast.type_map import pg_type_code_to_pg_type, pg_type_to_feast_value_type
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/online_stores/contrib/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
from feast.feature_view import FeatureView
from feast.infra.key_encoding_utils import serialize_entity_key
from feast.infra.online_stores.online_store import OnlineStore
from feast.infra.utils.postgres.connection_utils import _get_conn
from feast.infra.utils.postgres.postgres_config import PostgreSQLConfig
from feast.infra.utils.postgres.utils import _get_conn
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
from feast.protos.feast.types.Value_pb2 import Value as ValueProto
from feast.repo_config import RepoConfig
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry_stores/contrib/postgres/registry_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import psycopg2
from psycopg2 import sql

from feast.infra.utils.postgres.connection_utils import _get_conn
from feast.infra.utils.postgres.postgres_config import PostgreSQLConfig
from feast.infra.utils.postgres.utils import _get_conn
from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto
from feast.registry_store import RegistryStore
from feast.repo_config import RegistryConfig
Expand Down
0 ...ython/feast/infra/utils/postgres/utils.py → .../infra/utils/postgres/connection_utils.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion sdk/python/feast/templates/postgres/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import click
import psycopg2

from feast.infra.utils.postgres.connection_utils import df_to_postgres_table
from feast.infra.utils.postgres.postgres_config import PostgreSQLConfig
from feast.infra.utils.postgres.utils import df_to_postgres_table


def bootstrap():
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/feature_repos/universal/data_sources/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
PostgreSQLOfflineStoreConfig,
PostgreSQLSource,
)
from feast.infra.utils.postgres.utils import _get_conn, df_to_postgres_table
from feast.infra.utils.postgres.connection_utils import _get_conn, df_to_postgres_table
from feast.repo_config import FeastConfigBaseModel
from tests.integration.feature_repos.universal.data_source_creator import (
DataSourceCreator,
Expand Down