Skip to content

feat: Use a daemon thread to monitor the go feature server exclusively #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 23 commits into from
Mar 10, 2022
Merged

feat: Use a daemon thread to monitor the go feature server exclusively #2391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
612c962
feat: Use a daemon thread to monitor the go feature server exclusively
achals Mar 9, 2022
f14ac9b
fix workflow
achals Mar 9, 2022
78bbd66
Fix setup.py build_python_protos
achals Mar 9, 2022
8014662
CR comments
achals Mar 9, 2022
2ed95ec
mkdir is needed
achals Mar 9, 2022
bff6e92
explicit commit
achals Mar 9, 2022
7f33768
flush file explicitly
achals Mar 9, 2022
99fb066
Flush registry changes
achals Mar 9, 2022
88db3ec
Signal handler can only be triggered from main thread
achals Mar 9, 2022
31dbbf0
join on background thread when cancelling and update test
achals Mar 9, 2022
0f3afa3
fix redis
achals Mar 9, 2022
f5710ff
add back go_build.py
achals Mar 9, 2022
88e2c49
wait on grpc connection check
achals Mar 10, 2022
2fa1ccf
Add a more robust wait
achals Mar 10, 2022
92ff707
Add a sleep
achals Mar 10, 2022
54f1a08
Remove explicitt cleanup
achals Mar 10, 2022
67c7c17
More defensive
achals Mar 10, 2022
a79ec1c
Even more defensive
achals Mar 10, 2022
f8f0402
Stop join
achals Mar 10, 2022
635bd2a
Clean up the process to ensure next one is fine
achals Mar 10, 2022
3ea3fac
join thread
achals Mar 10, 2022
b83d4b3
remove a sleep
achals Mar 10, 2022
39a66e3
Cleanup
achals Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More defensive 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Mar 10, 2022
commit 67c7c1795e2646565a021dca269d97b5db6275a6
3 changes: 3 additions & 0 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,9 @@ def teardown(self):

entities = self.list_entities()

if self._go_server:
self._go_server.kill_go_server_explicitly()

self._get_provider().teardown_infra(self.project, tables, entities)
self._registry.teardown()

Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/go_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ def _start_go_server_use_thread(self):
self._go_server_started.wait()

def kill_go_server_explicitly(self):
self._go_server_started.clear()
self._go_server_background_thread.stop()
self._go_server_background_thread.join()

Expand Down
2 changes: 2 additions & 0 deletions sdk/python/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ def go_environment(request, worker_id: str):

def cleanup():
e.feature_store.teardown()
if e.feature_store._go_server:
e.feature_store._go_server.kill_go_server_explicitly()

request.addfinalizer(cleanup)
return e
Expand Down