Skip to content

fix: Use the correct dockerhub image tag when building feature servers #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Mar 7, 2022
Merged

fix: Use the correct dockerhub image tag when building feature servers #2372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a4894f8
fix: Use the correct dockerhub image tag when building feature servers
achals Mar 6, 2022
2756bce
Print attempt
achals Mar 6, 2022
9570ab8
Increase sleep interval
achals Mar 6, 2022
2e87f4e
More logging and sleep
achals Mar 7, 2022
da64fbf
change logging to debug
achals Mar 7, 2022
5a433ee
Change the dockerimage name
achals Mar 7, 2022
ee380a5
Change version to have periods
achals Mar 7, 2022
fba6523
Change version entirely
achals Mar 7, 2022
f459c9a
Undo unintended changes
achals Mar 7, 2022
7dabf79
Remove dead branch
achals Mar 7, 2022
b863739
Merge branch 'master' into achal/fix-lambda-tests
achals Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Undo unintended changes 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Mar 7, 2022
commit f459c9a95093e69e81ab8e958eeb8ecdafad861e
3 changes: 2 additions & 1 deletion sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}
# Port 12345 will chosen as default for redis node configuration because Redis Cluster is started off of nodes 6379 -> 6384. This causes conflicts in cli integration tests so we manually keep them separate.
REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}
REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:12345,db=0"}
REDIS_CLUSTER_CONFIG = {
"type": "redis",
"redis_type": "redis_cluster",
Expand All @@ -71,6 +71,7 @@
DEFAULT_FULL_REPO_CONFIGS.extend(
[
IntegrationTestRepoConfig(online_store=REDIS_CONFIG),
IntegrationTestRepoConfig(online_store=REDIS_CLUSTER_CONFIG),
# GCP configurations
IntegrationTestRepoConfig(
provider="gcp",
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def _get_online_features_dict_remotely(
request["features"] = features
else:
request["feature_service"] = features.name
for attempt in range(25):
for _ in range(25):
# Send the request to the remote feature server and get the response in JSON format
response = requests.post(
f"{endpoint}/get-online-features", json=request, timeout=30
Expand Down