Skip to content

ci: Set up go in the pr integration test workflow - #2367

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/setup-go-pr-integtest
Mar 6, 2022
Merged

ci: Set up go in the pr integration test workflow#2367
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/setup-go-pr-integtest

Conversation

@achals

@achals achals commented Mar 5, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
This PR needs to land before go subprocess tests can be enabled for #2339. The default version of go is too old.

Does this PR introduce a user-facing change?:

none

@achals
achals requested a review from a team as a code owner March 5, 2022 05:17
@achals
achals requested review from pyalex and removed request for a team March 5, 2022 05:17
@codecov-commenter

codecov-commenter commented Mar 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2367 (e64496e) into master (8e5a2f5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2367      +/-   ##
==========================================
- Coverage   58.25%   58.24%   -0.01%     
==========================================
  Files         118      118              
  Lines       10178    10182       +4     
==========================================
+ Hits         5929     5931       +2     
- Misses       4249     4251       +2     
Flag Coverage Δ
unittests 58.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hon/feast/infra/offline_stores/snowflake_source.py 57.72% <0.00%> (-0.13%) ⬇️
...thon/feast/infra/offline_stores/redshift_source.py 55.65% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5a2f5...e64496e. Read the comment docs.

@achals achals changed the title Set up go in the pr integration test workflow ci: Set up go in the pr integration test workflow Mar 5, 2022
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Achal Shah <achals@gmail.com>
@achals
achals force-pushed the achal/setup-go-pr-integtest branch from b8b8a8e to e64496e Compare March 5, 2022 23:45
@feast-ci-bot
feast-ci-bot merged commit a5fbd08 into feast-dev:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants