Skip to content

feat: Allow all snowflake python connector connection methods to be available to Feast #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 5 commits into from
Mar 4, 2022
Merged

feat: Allow all snowflake python connector connection methods to be available to Feast #2356

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8245267
Allow all snowflake python connector connection methods to be availab…
sfc-gh-madkins Mar 3, 2022
7a9b0e6
format/lint
sfc-gh-madkins Mar 3, 2022
e5cef2c
feat: have feast using snowflake python connector for authentication
sfc-gh-madkins Mar 4, 2022
1c84757
Merge branch 'master' into snowflake_connector
sfc-gh-madkins Mar 4, 2022
32018f0
fix random print
sfc-gh-madkins Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: have feast using snowflake python connector for authentication 
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
  • Loading branch information
@sfc-gh-madkins
sfc-gh-madkins committed Mar 4, 2022
commit e5cef2c02c5a7b70c755d5f5b6609151173eed2f
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/utils/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def get_snowflake_conn(config, autocommit=True) -> SnowflakeConnection:
for k, v in kwargs.items()
if k in ["role", "warehouse", "database", "schema_"]
]

kwargs["schema"] = kwargs.pop("schema_")
print(kwargs)
try:
conn = snowflake.connector.connect(
application="feast", autocommit=autocommit, **kwargs
Expand Down