Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
2366e85
State of feast
kevjumba Feb 25, 2022
20e82ea
Clean up changes
kevjumba Feb 26, 2022
55e7915
Fix random incorrect changes
kevjumba Feb 26, 2022
43794f7
Fix lint
kevjumba Feb 26, 2022
343ed00
Fix build errors
kevjumba Feb 26, 2022
55c458d
Fix lint
kevjumba Feb 26, 2022
b8ace43
Add spark offline store components to test against current integratio…
kevjumba Mar 1, 2022
d13119f
Fix lint
kevjumba Mar 1, 2022
4b56f55
Rename to pass checks
kevjumba Mar 1, 2022
6e278c4
Fix issues
kevjumba Mar 1, 2022
4bc67d8
Fix type checking issues
kevjumba Mar 1, 2022
c934edc
Fix lint
kevjumba Mar 1, 2022
e01d023
Clean up print statements for first review
kevjumba Mar 1, 2022
01ac14a
Fix lint
kevjumba Mar 1, 2022
26c8a01
Fix flake 8 lint tests
kevjumba Mar 1, 2022
6f8ce3c
Add warnings for alpha version release
kevjumba Mar 2, 2022
551eea1
Format
kevjumba Mar 2, 2022
1e7c2b4
Address review
kevjumba Mar 2, 2022
8e3e9a4
Address review
kevjumba Mar 2, 2022
cc1651e
Fix lint
kevjumba Mar 2, 2022
acf1c28
Add file store functionality
kevjumba Mar 2, 2022
65b113a
lint
kevjumba Mar 2, 2022
7adb8d2
Add example feature repo
kevjumba Mar 2, 2022
648f935
Update data source creator
kevjumba Mar 2, 2022
7b84ac1
Make cli work for feast init with spark
kevjumba Mar 2, 2022
b066a6f
Update the docs
kevjumba Mar 2, 2022
e0099ae
Clean up code
kevjumba Mar 2, 2022
86e74c0
Clean up more code
kevjumba Mar 2, 2022
6fe5b9e
Uncomment repo configs
kevjumba Mar 2, 2022
92c4f87
Fix setup.py
kevjumba Mar 2, 2022
18a2892
Update dependencies
kevjumba Mar 2, 2022
c644388
Fix ci dependencies
kevjumba Mar 3, 2022
9333130
Screwed up rebase
kevjumba Mar 3, 2022
6272f05
Screwed up rebase
kevjumba Mar 3, 2022
cf6bae1
Screwed up rebase
kevjumba Mar 3, 2022
0569b6d
Realign with master
kevjumba Mar 3, 2022
b02e51e
Fix accidental changes
kevjumba Mar 3, 2022
a161fad
Make type map change cleaner
kevjumba Mar 3, 2022
f7c618a
Address review comments
kevjumba Mar 3, 2022
c81fe31
Fix tests accidentally broken
kevjumba Mar 3, 2022
d790a1c
Add comments
kevjumba Mar 3, 2022
1408b8f
Reformat
kevjumba Mar 3, 2022
bf071b3
Fix logger
kevjumba Mar 3, 2022
62a92ac
Remove unused imports
kevjumba Mar 3, 2022
3ec6d22
Fix imports
kevjumba Mar 3, 2022
62ff185
Fix CI dependencies
adchia Mar 3, 2022
0dbc4e7
Prefix destinations with project name
kevjumba Mar 3, 2022
40cb4f8
Update comment
kevjumba Mar 3, 2022
4f5359a
Fix 3.8
kevjumba Mar 3, 2022
513d5bc
temporary fix
kevjumba Mar 3, 2022
8805884
rollback
kevjumba Mar 4, 2022
3ac3b71
update
kevjumba Mar 4, 2022
cfbaef5
Update ci?
kevjumba Mar 4, 2022
6abea5f
Move third party to contrib
kevjumba Mar 4, 2022
05aaeb8
Fix imports
kevjumba Mar 4, 2022
29a60d7
Remove third_party refactor
kevjumba Mar 4, 2022
b43417e
Revert ci requirements and update comment in type map
kevjumba Mar 4, 2022
1acc088
Revert 3.8-requirements
kevjumba Mar 4, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
State of feast
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
kevjumba committed Mar 4, 2022
commit 2366e85d0b3a507c0ff6f53df7c266d417d7af4b
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ def _get_bigquery_client(project: Optional[str] = None, location: Optional[str]

{{ featureview.name }}__base AS (
SELECT
subquery.*,
subquery.*,
entity_dataframe.entity_timestamp,
entity_dataframe.{{featureview.name}}__entity_row_unique_id
FROM {{ featureview.name }}__subquery AS subquery
Expand Down
2 changes: 2 additions & 0 deletions sdk/python/feast/infra/passthrough_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ def materialize_single_feature_view(

entities = []
for entity_name in feature_view.entities:
print("Entity Names!!")
print(entity_name)
entities.append(registry.get_entity(entity_name, project))

(
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/feast/repo_config.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from curses import raw
import os
from pathlib import Path
from typing import Any
Expand Down Expand Up @@ -345,9 +346,11 @@ def get_feature_server_config_from_type(feature_server_type: str):

def load_repo_config(repo_path: Path) -> RepoConfig:
config_path = repo_path / "feature_store.yaml"

print("INNNNNN")
print(repo_path)
with open(config_path) as f:
raw_config = yaml.safe_load(os.path.expandvars(f.read()))
print(raw_config)
try:
c = RepoConfig(**raw_config)
c.repo_path = repo_path
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"type": "redis",
"redis_type": "redis_cluster",
# Redis Cluster Port Forwarding is setup in "pr_integration_tests.yaml" under "Setup Redis Cluster".
"connection_string": "127.0.0.1:6001,127.0.0.1:6002,127.0.0.1:6003",
"connection_string": "127.0.0.1:7001,127.0.0.1:7002,127.0.0.1:7003",
}

# FULL_REPO_CONFIGS contains the repo configurations (e.g. provider, offline store,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -564,8 +564,8 @@ def test_online_retrieval(environment, universal_data_sources, full_feature_name
)


@pytest.mark.integration
@pytest.mark.universal
# @pytest.mark.integration
# @pytest.mark.universal
def test_online_store_cleanup(environment, universal_data_sources):
"""
Some online store implementations (like Redis) keep features from different features views
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def test_entity_inference_types_match(offline_types_test_fixtures):
)


@pytest.mark.integration
#@pytest.mark.integration
@pytest.mark.universal
def test_feature_get_historical_features_types_match(offline_types_test_fixtures):
environment, config, data_source, fv = offline_types_test_fixtures
Expand All @@ -169,7 +169,7 @@ def test_feature_get_historical_features_types_match(offline_types_test_fixtures
)
entity = driver()
fs.apply([fv, entity])

print("Applying")
features = [f"{fv.name}:value"]
entity_df = pd.DataFrame()
entity_df["driver_id"] = (
Expand All @@ -181,9 +181,11 @@ def test_feature_get_historical_features_types_match(offline_types_test_fixtures
ts - timedelta(hours=4),
ts - timedelta(hours=2),
]
print("Retrieving historical features")
historical_features = fs.get_historical_features(
entity_df=entity_df, features=features,
)
print("retrieved historical features")
# Note: Pandas doesn't play well with nan values in ints. BQ will also coerce to floats if there are NaNs
historical_features_df = historical_features.to_df()
print(historical_features_df)
Comment thread
adchia marked this conversation as resolved.
Outdated
Expand Down