Skip to content

fix: Rollback Redis-py to Redis-py-cluster #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 22 commits into from
Mar 3, 2022
Merged

fix: Rollback Redis-py to Redis-py-cluster #2347

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3651498
Roll back redis config and add tests back
kevjumba Feb 28, 2022
196912f
lint
kevjumba Feb 28, 2022
0513d61
Fix autogenerated import
kevjumba Feb 28, 2022
551ea5d
Fix lint
kevjumba Feb 28, 2022
9f55a2a
Add redis-py-cluster back
kevjumba Feb 28, 2022
2e16f1e
Fix dask ci
kevjumba Feb 28, 2022
d70c1a5
Regenerate using respective python 3 versions
kevjumba Feb 28, 2022
f4160ad
Change test_entity_ttl test
kevjumba Mar 1, 2022
c5425d7
Fix lint
kevjumba Mar 1, 2022
e326820
Change integration workflow
kevjumba Mar 1, 2022
00fddbe
Temporarily disable for testing
kevjumba Mar 1, 2022
35232c3
Continue making work
kevjumba Mar 1, 2022
247ecb3
Continue making work
kevjumba Mar 1, 2022
9d921e8
Fix workflow
kevjumba Mar 1, 2022
c7ae586
Fix workflow
kevjumba Mar 1, 2022
659a3db
Update port numbers
kevjumba Mar 1, 2022
ce38071
Update pr integration tests
kevjumba Mar 2, 2022
fbe94f1
Reenable rest of tests
kevjumba Mar 2, 2022
43fe913
Update data source creator
kevjumba Mar 2, 2022
e5fedcc
Fix integration test
kevjumba Mar 2, 2022
a321d54
Clean up code
kevjumba Mar 2, 2022
4a0d350
Somehow removed the key components -,-
kevjumba Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change test_entity_ttl test 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Mar 2, 2022
commit f4160ade756fc012bbcb3bfdb768a80a95c03d7d
17 changes: 17 additions & 0 deletions sdk/python/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,23 @@ def cleanup():
request.addfinalizer(cleanup)
return construct_universal_test_data(environment)

@pytest.fixture(scope="session")
def redis_universal_data_sources(request, local_redis_environment):
entities = construct_universal_entities()
datasets = construct_universal_datasets(
entities, local_redis_environment.start_date, local_redis_environment.end_date
)
datasources = construct_universal_data_sources(
datasets, local_redis_environment.data_source_creator
)

def cleanup():
# logger.info("Running cleanup in %s, Request: %s", worker_id, request.param)
local_redis_environment.data_source_creator.teardown()

request.addfinalizer(cleanup)
return entities, datasets, datasources


@pytest.fixture(scope="session")
def e2e_data_sources(environment: Environment, request):
Expand Down
9 changes: 6 additions & 3 deletions sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,16 @@


@pytest.mark.integration
def test_entity_ttl_online_store(local_redis_environment, universal_data_sources):
def test_entity_ttl_online_store(local_redis_environment, redis_universal_data_sources):
if os.getenv("FEAST_IS_LOCAL_TEST", "False") == "True":
return
fs = local_redis_environment.feature_store
# setting ttl setting in online store to 1 second
fs.config.online_store.key_ttl_seconds = 1
entities, datasets, data_sources = universal_data_sources
driver_hourly_stats = create_driver_hourly_stats_feature_view(data_sources.driver)
entities, datasets, data_sources = redis_universal_data_sources
driver_hourly_stats = create_driver_hourly_stats_feature_view(
data_sources["driver"]
)
driver_entity = driver()

# Register Feature View and Entity
Expand Down Expand Up @@ -94,6 +96,7 @@ def test_entity_ttl_online_store(local_redis_environment, universal_data_sources
assertpy.assert_that(df["conv_rate"].iloc[0]).is_none()



# TODO: make this work with all universal (all online store types)
@pytest.mark.integration
def test_write_to_online_store_event_check(local_redis_environment):
Expand Down