Skip to content

feat: Metadata changes & making data sources top level objects to power Feast UI #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 12 commits into from
Mar 4, 2022
Merged

feat: Metadata changes & making data sources top level objects to power Feast UI #2336

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dcf57f7
Squash commits for metadata changes
adchia Feb 25, 2022
d7374f5
tests
adchia Feb 26, 2022
88b8dda
Add more tests
adchia Feb 26, 2022
59b6eb6
lint
adchia Feb 26, 2022
b4a73df
Add apply test
adchia Feb 26, 2022
5509e43
Add apply test
adchia Feb 26, 2022
8c0ff23
Add apply test
adchia Feb 26, 2022
d8b5784
lint
adchia Feb 26, 2022
1f6e541
fix bigquery source
adchia Mar 2, 2022
fcfca3b
fix test
adchia Mar 4, 2022
bdd220f
fix spark source
adchia Mar 4, 2022
75b2cc2
fix spark source
adchia Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Mar 4, 2022
commit d8b5784244f2ec10c2f14ba6562a7b3e6ffad4d3
14 changes: 12 additions & 2 deletions sdk/python/tests/integration/registration/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,14 +463,24 @@ def test_apply_data_source(test_registry: Registry):
test_registry.apply_data_source(batch_source, project, commit=False)
test_registry.apply_feature_view(fv1, project, commit=True)

registry_feature_view = test_registry.list_feature_views(project)[0]
registry_feature_views = test_registry.list_feature_views(project)
registry_data_sources = test_registry.list_data_sources(project)
assert len(registry_feature_views) == 1
assert len(registry_data_sources) == 1
registry_feature_view = registry_feature_views[0]
assert registry_feature_view.batch_source == batch_source
registry_data_source = registry_data_sources[0]
assert registry_data_source == batch_source

# Check that change to batch source propagates
batch_source.event_timestamp_column = "new_ts_col"
test_registry.apply_data_source(batch_source, project, commit=False)
test_registry.apply_feature_view(fv1, project, commit=True)
registry_feature_view = test_registry.list_feature_views(project)[0]
registry_feature_views = test_registry.list_feature_views(project)
registry_data_sources = test_registry.list_data_sources(project)
assert len(registry_feature_views) == 1
assert len(registry_data_sources) == 1
registry_feature_view = registry_feature_views[0]
assert registry_feature_view.batch_source == batch_source
registry_batch_source = test_registry.list_data_sources(project)[0]
assert registry_batch_source == batch_source
Expand Down