Skip to content

feat: Allowing password based authentication and SSL for Redis in Java feature server #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 7 commits into from
Feb 23, 2022
Merged

feat: Allowing password based authentication and SSL for Redis in Java feature server #2322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
429db38
Enabling password authentication and SSL in Redis clusters for the Ja…
adchia Feb 18, 2022
f150646
lint
adchia Feb 18, 2022
08dde62
add test
adchia Feb 18, 2022
01afe5b
Address comments
adchia Feb 18, 2022
9465882
Address comments
adchia Feb 18, 2022
9b0f470
lint
adchia Feb 23, 2022
83182f1
lint
adchia Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comments 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Feb 18, 2022
commit 01afe5b062092b6d750feef621f2ffae9245948a
3 changes: 2 additions & 1 deletion java/serving/src/main/java/feast/serving/config/ApplicationProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ public RedisClusterStoreConfig getRedisClusterConfig() {
}

if (!this.config.containsKey("timeout") || this.config.get("timeout") == null) {
throw new RuntimeException("Redis cluster config does not have 'timeout' specified");
throw new IllegalArgumentException(
"Redis cluster config does not have 'timeout' specified");
}

boolean ssl = false;
Expand Down
1 change: 1 addition & 0 deletions ...tors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisClusterClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public static RedisClientAdapter create(RedisClusterStoreConfig config) {
if (config.getSsl()) {
redisURI.setSsl(true);
}
redisURI.setTimeout(config.getTimeout());
return redisURI;
Comment thread
adchia marked this conversation as resolved.
})
.collect(Collectors.toList());
Expand Down