Skip to content

Update CONTRIBUTING.md - #2282

Merged
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
adchia:improveContributorDocs
Feb 7, 2022
Merged

Update CONTRIBUTING.md#2282
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
adchia:improveContributorDocs

Conversation

@adchia

@adchia adchia commented Feb 4, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Updates contributor docs to include

  • A PR checklist to follow
  • References to snowflake dev environment
  • Local integration tests
  • Overriding full integration tests (e.g. excluding clouds)
  • Warnings around using IDE GitHub integrations vs commit signing.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
adchia requested a review from a team as a code owner February 4, 2022 15:48
@adchia
adchia requested review from kevjumba and removed request for a team February 4, 2022 15:48

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit b86a99b into feast-dev:master Feb 7, 2022
adchia added a commit that referenced this pull request Feb 15, 2022
* Add reference to local integration test setup

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Add commit signing warning

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Add reference to manually configuring tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Add PR checklist

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Add PR checklist

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
adchia deleted the improveContributorDocs branch March 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants