Skip to content

Optimize _populate_result_rows_from_feature_view #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 10 commits into from
Jan 26, 2022
Merged

Optimize _populate_result_rows_from_feature_view #2223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e5539e
Optimize `_populate_result_rows_from_feature_view`
judahrand Jan 18, 2022
0cb1e76
Initialize the minimum number of EntityKeyProtos per FeatureView
judahrand Jan 18, 2022
6ed7459
Refactor for readability
judahrand Jan 21, 2022
9602567
Update `mypy` and `mypy-protobuf` to allow Enum typing
judahrand Jan 21, 2022
82dc11f
Fix newly detected linting errors
judahrand Jan 21, 2022
623a3df
Fix test failure
judahrand Jan 21, 2022
0d91f6b
Remove accidentally committed typo
judahrand Jan 21, 2022
c49bcd4
Define Entity type
judahrand Jan 21, 2022
39a5812
Ensure entities are sorted for `itertools.groupby`
judahrand Jan 25, 2022
c81dc27
Add simple unittest for `_get_unique_entities`
judahrand Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update mypy and mypy-protobuf to allow Enum typing 
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
  • Loading branch information
@judahrand
judahrand committed Jan 21, 2022
commit 9602567e9d61a9196f8c32c0ed64ed8a4e030139
26 changes: 16 additions & 10 deletions sdk/python/requirements/py3.7-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# pip-compile --extra=ci --output-file=requirements/py3.7-ci-requirements.txt
#
absl-py==0.12.0
absl-py==1.0.0
# via tensorflow-metadata
adal==1.2.7
# via
Expand Down Expand Up @@ -55,11 +55,11 @@ babel==2.9.1
# via sphinx
black==19.10b0
# via feast (setup.py)
boto3==1.20.38
boto3==1.20.40
# via
# feast (setup.py)
# moto
botocore==1.23.38
botocore==1.23.40
# via
# boto3
# moto
Expand Down Expand Up @@ -213,7 +213,7 @@ grpcio-testing==1.34.0
# via feast (setup.py)
grpcio-tools==1.34.0
# via feast (setup.py)
h11==0.12.0
h11==0.13.0
# via uvicorn
hiredis==2.0.0
# via feast (setup.py)
Expand Down Expand Up @@ -279,7 +279,7 @@ mmh3==3.0.0
# via feast (setup.py)
mock==2.0.0
# via feast (setup.py)
moto==2.3.2
moto==3.0.0
# via feast (setup.py)
msal==1.16.0
# via
Expand All @@ -299,13 +299,13 @@ multidict==5.2.0
# via
# aiohttp
# yarl
mypy==0.790
mypy==0.931
# via feast (setup.py)
mypy-extensions==0.4.3
# via
# mypy
# typing-inspect
mypy-protobuf==1.24
mypy-protobuf==3.1.0
# via feast (setup.py)
nodeenv==1.6.0
# via pre-commit
Expand Down Expand Up @@ -396,7 +396,7 @@ pyjwt[crypto]==2.3.0
# via
# adal
# msal
pyparsing==3.0.6
pyparsing==3.0.7
# via
# httplib2
# packaging
Expand Down Expand Up @@ -528,7 +528,7 @@ tabulate==0.8.9
# via feast (setup.py)
tenacity==8.0.1
# via feast (setup.py)
tensorflow-metadata==1.5.0
tensorflow-metadata==1.6.0
# via feast (setup.py)
testcontainers==3.4.2
# via feast (setup.py)
Expand All @@ -541,19 +541,25 @@ toml==0.10.2
tomli==2.0.0
# via
# coverage
# mypy
# pep517
tqdm==4.62.3
# via feast (setup.py)
typed-ast==1.4.3
typed-ast==1.5.1
# via
# black
# mypy
types-futures==3.3.7
# via types-protobuf
types-protobuf==3.19.5
# via mypy-protobuf
typing-extensions==4.0.1
# via
# aiohttp
# anyio
# asgiref
# async-timeout
# h11
# importlib-metadata
# jsonschema
# libcst
Expand Down
7 changes: 4 additions & 3 deletions sdk/python/requirements/py3.7-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# pip-compile --output-file=requirements/py3.7-requirements.txt
#
absl-py==0.12.0
absl-py==1.0.0
# via tensorflow-metadata
anyio==3.5.0
# via starlette
Expand Down Expand Up @@ -47,7 +47,7 @@ grpcio==1.43.0
# grpcio-reflection
grpcio-reflection==1.43.0
# via feast (setup.py)
h11==0.12.0
h11==0.13.0
# via uvicorn
httptools==0.3.0
# via uvicorn
Expand Down Expand Up @@ -133,7 +133,7 @@ tabulate==0.8.9
# via feast (setup.py)
tenacity==8.0.1
# via feast (setup.py)
tensorflow-metadata==1.5.0
tensorflow-metadata==1.6.0
# via feast (setup.py)
toml==0.10.2
# via feast (setup.py)
Expand All @@ -143,6 +143,7 @@ typing-extensions==4.0.1
# via
# anyio
# asgiref
# h11
# importlib-metadata
# jsonschema
# pydantic
Expand Down
29 changes: 16 additions & 13 deletions sdk/python/requirements/py3.8-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# pip-compile --extra=ci --output-file=requirements/py3.8-ci-requirements.txt
#
absl-py==0.12.0
absl-py==1.0.0
# via tensorflow-metadata
adal==1.2.7
# via
Expand Down Expand Up @@ -53,11 +53,11 @@ babel==2.9.1
# via sphinx
black==19.10b0
# via feast (setup.py)
boto3==1.20.38
boto3==1.20.40
# via
# feast (setup.py)
# moto
botocore==1.23.38
botocore==1.23.40
# via
# boto3
# moto
Expand Down Expand Up @@ -211,7 +211,7 @@ grpcio-testing==1.34.0
# via feast (setup.py)
grpcio-tools==1.34.0
# via feast (setup.py)
h11==0.12.0
h11==0.13.0
# via uvicorn
hiredis==2.0.0
# via feast (setup.py)
Expand Down Expand Up @@ -265,7 +265,7 @@ mmh3==3.0.0
# via feast (setup.py)
mock==2.0.0
# via feast (setup.py)
moto==2.3.2
moto==3.0.0
# via feast (setup.py)
msal==1.16.0
# via
Expand All @@ -285,13 +285,13 @@ multidict==5.2.0
# via
# aiohttp
# yarl
mypy==0.790
mypy==0.931
# via feast (setup.py)
mypy-extensions==0.4.3
# via
# mypy
# typing-inspect
mypy-protobuf==1.24
mypy-protobuf==3.1.0
# via feast (setup.py)
nodeenv==1.6.0
# via pre-commit
Expand Down Expand Up @@ -382,7 +382,7 @@ pyjwt[crypto]==2.3.0
# via
# adal
# msal
pyparsing==3.0.6
pyparsing==3.0.7
# via
# httplib2
# packaging
Expand Down Expand Up @@ -514,7 +514,7 @@ tabulate==0.8.9
# via feast (setup.py)
tenacity==8.0.1
# via feast (setup.py)
tensorflow-metadata==1.5.0
tensorflow-metadata==1.6.0
# via feast (setup.py)
testcontainers==3.4.2
# via feast (setup.py)
Expand All @@ -527,13 +527,16 @@ toml==0.10.2
tomli==2.0.0
# via
# coverage
# mypy
# pep517
tqdm==4.62.3
# via feast (setup.py)
typed-ast==1.4.3
# via
# black
# mypy
typed-ast==1.5.1
# via black
types-futures==3.3.7
# via types-protobuf
types-protobuf==3.19.5
# via mypy-protobuf
typing-extensions==4.0.1
# via
# libcst
Expand Down
6 changes: 3 additions & 3 deletions sdk/python/requirements/py3.8-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# pip-compile --output-file=requirements/py3.8-requirements.txt
#
absl-py==0.12.0
absl-py==1.0.0
# via tensorflow-metadata
anyio==3.5.0
# via starlette
Expand Down Expand Up @@ -47,7 +47,7 @@ grpcio==1.43.0
# grpcio-reflection
grpcio-reflection==1.43.0
# via feast (setup.py)
h11==0.12.0
h11==0.13.0
# via uvicorn
httptools==0.3.0
# via uvicorn
Expand Down Expand Up @@ -129,7 +129,7 @@ tabulate==0.8.9
# via feast (setup.py)
tenacity==8.0.1
# via feast (setup.py)
tensorflow-metadata==1.5.0
tensorflow-metadata==1.6.0
# via feast (setup.py)
toml==0.10.2
# via feast (setup.py)
Expand Down
29 changes: 16 additions & 13 deletions sdk/python/requirements/py3.9-ci-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# pip-compile --extra=ci --output-file=requirements/py3.9-ci-requirements.txt
#
absl-py==0.12.0
absl-py==1.0.0
# via tensorflow-metadata
adal==1.2.7
# via
Expand Down Expand Up @@ -53,11 +53,11 @@ babel==2.9.1
# via sphinx
black==19.10b0
# via feast (setup.py)
boto3==1.20.38
boto3==1.20.40
# via
# feast (setup.py)
# moto
botocore==1.23.38
botocore==1.23.40
# via
# boto3
# moto
Expand Down Expand Up @@ -211,7 +211,7 @@ grpcio-testing==1.34.0
# via feast (setup.py)
grpcio-tools==1.34.0
# via feast (setup.py)
h11==0.12.0
h11==0.13.0
# via uvicorn
hiredis==2.0.0
# via feast (setup.py)
Expand Down Expand Up @@ -263,7 +263,7 @@ mmh3==3.0.0
# via feast (setup.py)
mock==2.0.0
# via feast (setup.py)
moto==2.3.2
moto==3.0.0
# via feast (setup.py)
msal==1.16.0
# via
Expand All @@ -283,13 +283,13 @@ multidict==5.2.0
# via
# aiohttp
# yarl
mypy==0.790
mypy==0.931
# via feast (setup.py)
mypy-extensions==0.4.3
# via
# mypy
# typing-inspect
mypy-protobuf==1.24
mypy-protobuf==3.1.0
# via feast (setup.py)
nodeenv==1.6.0
# via pre-commit
Expand Down Expand Up @@ -380,7 +380,7 @@ pyjwt[crypto]==2.3.0
# via
# adal
# msal
pyparsing==3.0.6
pyparsing==3.0.7
# via
# httplib2
# packaging
Expand Down Expand Up @@ -512,7 +512,7 @@ tabulate==0.8.9
# via feast (setup.py)
tenacity==8.0.1
# via feast (setup.py)
tensorflow-metadata==1.5.0
tensorflow-metadata==1.6.0
# via feast (setup.py)
testcontainers==3.4.2
# via feast (setup.py)
Expand All @@ -525,13 +525,16 @@ toml==0.10.2
tomli==2.0.0
# via
# coverage
# mypy
# pep517
tqdm==4.62.3
# via feast (setup.py)
typed-ast==1.4.3
# via
# black
# mypy
typed-ast==1.5.1
# via black
types-futures==3.3.7
# via types-protobuf
types-protobuf==3.19.5
# via mypy-protobuf
typing-extensions==4.0.1
# via
# libcst
Expand Down
6 changes: 3 additions & 3 deletions sdk/python/requirements/py3.9-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# pip-compile --output-file=requirements/py3.9-requirements.txt
#
absl-py==0.12.0
absl-py==1.0.0
# via tensorflow-metadata
anyio==3.5.0
# via starlette
Expand Down Expand Up @@ -47,7 +47,7 @@ grpcio==1.43.0
# grpcio-reflection
grpcio-reflection==1.43.0
# via feast (setup.py)
h11==0.12.0
h11==0.13.0
# via uvicorn
httptools==0.3.0
# via uvicorn
Expand Down Expand Up @@ -127,7 +127,7 @@ tabulate==0.8.9
# via feast (setup.py)
tenacity==8.0.1
# via feast (setup.py)
tensorflow-metadata==1.5.0
tensorflow-metadata==1.6.0
# via feast (setup.py)
toml==0.10.2
# via feast (setup.py)
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@
"minio==7.1.0",
"mock==2.0.0",
"moto",
"mypy==0.790",
"mypy-protobuf==1.24",
"mypy==0.931",
"mypy-protobuf==3.1.0",
"avro==1.10.0",
"gcsfs",
"urllib3>=1.25.4",
Expand Down