Skip to content

Merge feast-snowflake plugin into main repo with documentation #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 21 commits into from
Jan 31, 2022
Merged

Merge feast-snowflake plugin into main repo with documentation #2193

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f359ee3
Add backticks to left_table_query_string (#2250)
dmille Jan 27, 2022
49c5536
Delete entity key from Redis only when all attached feature views are…
pyalex Jan 28, 2022
68d2c1a
historical_field_mappings2 merge for one sign off commit (#2252)
michelle-rascati-sp Jan 28, 2022
507ca6b
Correct inconsistent dependency (#2255)
judahrand Jan 28, 2022
660a7d0
Add snowflake environment variables to allow testing on snowflake inf…
sfc-gh-madkins Jan 29, 2022
d44561b
Return `UNIX_TIMESTAMP` as Python `datetime` (#2244)
judahrand Jan 29, 2022
e617a06
Feast plan clean up (#2256)
felixwang9817 Jan 30, 2022
bb17968
Squash commits
adchia Jan 30, 2022
1152687
Add error type and refactor query execution to have retries
adchia Jan 30, 2022
9a2e0a5
Handle more snowflake errors
adchia Jan 30, 2022
7c24117
Fix lint errors
adchia Jan 31, 2022
5f8fbf4
Fix lint errors
adchia Jan 31, 2022
80627c5
Fix lint errors
adchia Jan 31, 2022
12c92f1
Fix wrong import
adchia Jan 31, 2022
17874d7
modify registry.db s3 object initialization to work in S3 subdirector…
NalinGHub Jan 30, 2022
61172b3
clean up docs
sfc-gh-madkins Jan 31, 2022
26270bb
Merge branch 'feast-dev:master' into master
sfc-gh-madkins Jan 31, 2022
9e952b2
lint-python
sfc-gh-madkins Jan 31, 2022
12b2657
Merge branch 'master' of github.com:sfc-gh-madkins/feast
sfc-gh-madkins Jan 31, 2022
3ddaf0d
fixed historical test
sfc-gh-madkins Jan 31, 2022
6c29bfb
fixed historical test
sfc-gh-madkins Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint errors 
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>
  • Loading branch information
@adchia @sfc-gh-madkins
adchia authored and sfc-gh-madkins committed Jan 31, 2022
commit 5f8fbf4bca2e34a3ac74130fb6db7f9101754f7e
5 changes: 0 additions & 5 deletions sdk/python/feast/infra/utils/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,11 @@
from logging import getLogger
from tempfile import TemporaryDirectory
from typing import (
Any,
Dict,
Iterator,
List,
Optional,
Sequence,
Tuple,
TypeVar,
Union,
cast,
)

Expand Down Expand Up @@ -238,7 +234,6 @@ def write_pandas(
result_cursor = cursor.execute(copy_into_sql, _is_internal=True)
if result_cursor is None:
raise SnowflakeQueryUnknownError(copy_into_sql)
copy_results = cast(List[Tuple], result_cursor.fetchall())
result_cursor.close()


Expand Down