Refactor tag methods to infer created, deleted, and kept repo objects - #2142
Conversation
…kept Signed-off-by: Achal Shah <achals@gmail.com>
| ) | ||
|
|
||
| @classmethod | ||
| def from_proto(cls, regsitry_proto: RegistryProto): |
There was a problem hiding this comment.
nit: regsitry is mispelled
There was a problem hiding this comment.
q: why do we need a from_proto for the registry? I thought the registry contents would always be persisted by the registry store
to clarify, even when we want to compare two registries, we will be comparing protos; I don't think we'll need to reconstruct a registry from a proto?
There was a problem hiding this comment.
yeah fair, I can change this to operate on the protos themselves. I think I misunderstood earlier
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2142 +/- ##
===========================================
+ Coverage 57.88% 83.34% +25.45%
===========================================
Files 101 102 +1
Lines 8176 8213 +37
===========================================
+ Hits 4733 6845 +2112
+ Misses 3443 1368 -2075
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
This is a first PR to support the
feast plancommand, as it applies to FCOs. It also adds adiff_betewenmethod for Registry objects, which is not complete in its implementation at this point.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: