Pre compute the timestamp range for feature views by judahrand · Pull Request #2103 · feast-dev/feast

judahrand · 2021-12-03T11:00:28Z

What this PR does / why we need it:
This allows BigQuery to take advantage of Partitions when querying
historical features.

Which issue(s) this PR fixes:

Fixes #2083 (doesn't necessarily completely fix but does fix in at least one case)

Does this PR introduce a user-facing change?:

None

feast-ci-bot · 2021-12-03T11:00:39Z

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov-commenter · 2021-12-03T11:34:18Z

Codecov Report

Merging #2103 (11a695f) into master (5560caf) will decrease coverage by 0.15%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2103      +/-   ##
==========================================
- Coverage   57.88%   57.73%   -0.16%     
==========================================
  Files         101      101              
  Lines        8176     8205      +29     
==========================================
+ Hits         4733     4737       +4     
- Misses       3443     3468      +25

Flag	Coverage Δ
unittests	`57.73% <33.33%> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/local.py	`92.85% <ø> (+5.62%)`	⬆️
sdk/python/feast/infra/offline_stores/bigquery.py	`31.35% <13.33%> (-1.79%)`	⬇️
sdk/python/feast/infra/offline_stores/redshift.py	`38.57% <20.00%> (-2.70%)`	⬇️
...python/feast/infra/offline_stores/offline_utils.py	`44.55% <50.00%> (-0.13%)`	⬇️
sdk/python/feast/utils.py	`90.00% <75.00%> (-10.00%)`	⬇️
sdk/python/feast/infra/online_stores/sqlite.py	`95.50% <100.00%> (+0.88%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5560caf...11a695f. Read the comment docs.

judahrand · 2021-12-16T11:58:49Z

I believe this is functional but it is so hard to tell will how flakey the AWS tests are 😢 Even just what seems like random connection errors.

pyalex · 2021-12-17T20:36:49Z

/lgtm

This allows BigQuery to take advantage of Partitions when querying historical features. Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

judahrand · 2021-12-20T22:46:37Z

@pyalex Could we get this merged once the tests run. I keep having to merge in conflicts from master. Not sure why the docker build is failing?

judahrand · 2021-12-21T00:22:12Z

@pyalex all good here

achals

/lgtm

feast-ci-bot · 2021-12-21T04:28:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, judahrand, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

judahrand requested a review from a team as a code owner December 3, 2021 11:00

judahrand requested review from achals and removed request for a team December 3, 2021 11:00

feast-ci-bot added do-not-merge/release-note-label-needed needs-kind release-note-none and removed do-not-merge/release-note-label-needed labels Dec 3, 2021

feast-ci-bot added needs-ok-to-test size/L labels Dec 3, 2021

github-actions Bot assigned tsotnet Dec 3, 2021

judahrand added kind/feature New feature or request ok-to-test and removed size/L needs-ok-to-test needs-kind ok-to-test labels Dec 3, 2021

feast-ci-bot added the size/L label Dec 3, 2021

judahrand force-pushed the bq-partition branch 2 times, most recently from eb75ce9 to 76a64b8 Compare December 3, 2021 11:28

judahrand force-pushed the bq-partition branch 5 times, most recently from 89cd59a to b5a8d26 Compare December 3, 2021 13:55

judahrand added ok-to-test and removed ok-to-test labels Dec 3, 2021

judahrand force-pushed the bq-partition branch 7 times, most recently from 488afd5 to caaa839 Compare December 16, 2021 11:06

pyalex approved these changes Dec 17, 2021

View reviewed changes

feast-ci-bot assigned pyalex Dec 17, 2021

feast-ci-bot added the lgtm label Dec 17, 2021

judahrand added 5 commits December 20, 2021 22:40

Pre compute the timestamp range for feature views

99cf7ff

This allows BigQuery to take advantage of Partitions when querying historical features. Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

Correct comparison typo

a8fede7

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

Use isinstance rather than type

08d6669

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

Convert min and max event_timestamp to UTC

aa6537e

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

Move _to_naive_utc to avoid circular import

3d8a471

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

judahrand force-pushed the bq-partition branch from caaa839 to 3d8a471 Compare December 20, 2021 22:42

feast-ci-bot removed the lgtm label Dec 20, 2021

achals approved these changes Dec 21, 2021

View reviewed changes

feast-ci-bot assigned achals Dec 21, 2021

feast-ci-bot added the lgtm label Dec 21, 2021

feast-ci-bot added the approved label Dec 21, 2021

feast-ci-bot merged commit 2e41d03 into feast-dev:master Dec 21, 2021

judahrand deleted the bq-partition branch January 19, 2022 12:21

jbvaningen mentioned this pull request Feb 24, 2022

SparkOfflineStore is not compatible with feast>=0.17 Adyen/feast-spark-offline-store#14

Closed

tpvasconcelos mentioned this pull request Mar 7, 2022

Pre compute the timestamp range for feature views Shopify/feast-trino#49

Closed

Navigation Menu

Uh oh!

Pre compute the timestamp range for feature views - #2103

Pre compute the timestamp range for feature views#2103
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
judahrand:bq-partition

judahrand commented Dec 3, 2021 •

edited

Loading

Uh oh!

feast-ci-bot commented Dec 3, 2021

Uh oh!

codecov-commenter commented Dec 3, 2021 •

edited

Loading

Uh oh!

judahrand commented Dec 16, 2021

Uh oh!

pyalex commented Dec 17, 2021

Uh oh!

judahrand commented Dec 20, 2021

Uh oh!

judahrand commented Dec 21, 2021

Uh oh!

achals left a comment

Uh oh!

feast-ci-bot commented Dec 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

judahrand commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feast-ci-bot commented Dec 3, 2021

Uh oh!

codecov-commenter commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

judahrand commented Dec 16, 2021

Uh oh!

pyalex commented Dec 17, 2021

Uh oh!

judahrand commented Dec 20, 2021

Uh oh!

judahrand commented Dec 21, 2021

Uh oh!

achals left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Dec 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

judahrand commented Dec 3, 2021 •

edited

Loading

codecov-commenter commented Dec 3, 2021 •

edited

Loading