Do not attempt to compute ODFVs when there are no ODFVs - #2090
Merged
Conversation
felixwang9817
requested review from
a team,
achals,
adchia,
tsotnet and
woop
as code owners
November 25, 2021 01:59
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
===========================================
- Coverage 83.44% 58.09% -25.36%
===========================================
Files 100 100
Lines 8077 8077
===========================================
- Hits 6740 4692 -2048
- Misses 1337 3385 +2048
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
achals
requested changes
Nov 29, 2021
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
force-pushed
the
odfv_bug
branch
from
November 30, 2021 19:15
e10337b to
ee1c2e2
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
achals
approved these changes
Dec 2, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: This PR ensures that we do not attempt to compute ODFVs in
RetrievalJobswhen there are no ODFVs.Which issue(s) this PR fixes:
Fixes #2072
Does this PR introduce a user-facing change?: