Skip to content

Add Prow job for unit testing Python SDK - #209

Merged
budi merged 4 commits into
masterfrom
unit-test
May 31, 2019
Merged

Add Prow job for unit testing Python SDK#209
budi merged 4 commits into
masterfrom
unit-test

Conversation

@davidheryanto

@davidheryanto davidheryanto commented May 30, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

@feast-ci-bot

feast-ci-bot commented May 30, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto

davidheryanto commented May 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

/hold
Waiting for #207 to be merged because it will fix the integration-test

Due to newer openjdk official image has different abosolute path to java exec
No longer at /usr/bin/java

Current integration test fail due to Feast core and serving image cannot start because of invalid java path

@feast-ci-bot

feast-ci-bot commented May 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@davidheryanto: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
unit-test-cli 4ee4997 link /test unit-test-cli

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidheryanto

davidheryanto commented May 30, 2019

Copy link
Copy Markdown
Collaborator Author

/hold cancel

@davidheryanto davidheryanto mentioned this pull request May 31, 2019
Merged
@budi

budi commented May 31, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@budi

budi commented May 31, 2019

Copy link
Copy Markdown
Contributor

cli test is failing because golang map ordering is sometimes jumbled up (in the test we assumed it's ordered)

@budi
budi merged commit d500001 into master May 31, 2019
@feast-ci-bot

feast-ci-bot commented May 31, 2019

Copy link
Copy Markdown
Collaborator

@davidheryanto: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidheryanto
davidheryanto deleted the unit-test branch July 16, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradithya pradithya Awaiting requested review from pradithya
@thirteen37 thirteen37 Awaiting requested review from thirteen37
@tims tims Awaiting requested review from tims
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@budi budi

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidheryanto @feast-ci-bot @budi