Skip to content

Duplicate feast apply bug - #2087

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
felixwang9817:duplicate_feast_apply_bug
Nov 24, 2021
Merged

Duplicate feast apply bug#2087
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
felixwang9817:duplicate_feast_apply_bug

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented Nov 24, 2021

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: This PR ensures that the dummy entity does not get deleted on feast apply.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817
Refactor feast registry-dump cli command
e3a4cb7 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Test that running feast apply twice does not change registry contents
b9b64f4 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Ensure that Registry.to_dict sorts contents
719134e 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Do not remove dummy entity
0387e2a 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
felixwang9817 requested review from a team, achals, adchia, tsotnet and woop as code owners November 24, 2021 21:55
@codecov-commenter

codecov-commenter commented Nov 24, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2087 (0387e2a) into master (0356181) will increase coverage by 0.13%.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2087      +/-   ##
==========================================
+ Coverage   83.30%   83.43%   +0.13%     
==========================================
  Files         100      100              
  Lines        8072     8077       +5     
==========================================
+ Hits         6724     6739      +15     
+ Misses       1348     1338      -10
Flag Coverage Δ
integrationtests 73.85% <79.16%> (+0.14%) ⬆️
unittests 58.10% <20.83%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 44.17% <33.33%> (+1.59%) ⬆️
sdk/python/feast/registry.py 80.52% <83.33%> (+0.10%) ⬆️
.../python/tests/integration/registration/test_cli.py 100.00% <100.00%> (ø)
sdk/python/feast/feature_service.py 82.60% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0356181...0387e2a. Read the comment docs.

@felixwang9817

felixwang9817 commented Nov 24, 2021

Copy link
Copy Markdown
Collaborator Author

/ok-to-test

@felixwang9817

felixwang9817 commented Nov 24, 2021

Copy link
Copy Markdown
Collaborator Author

/kind bug

achals
achals approved these changes Nov 24, 2021
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Nov 24, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 54d0f3a into feast-dev:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes
@adchia adchia Awaiting requested review from adchia
@tsotnet tsotnet Awaiting requested review from tsotnet
@woop woop Awaiting requested review from woop

Assignees

@achals achals

Labels

approved kind/bug lgtm ok-to-test release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @achals @tsotnet