Skip to content

fix create_dataset - #208

Merged
feast-ci-bot merged 14 commits into
feast-dev:masterfrom
budi:create_dataset
Jun 12, 2019
Merged

fix create_dataset#208
feast-ci-bot merged 14 commits into
feast-dev:masterfrom
budi:create_dataset

Conversation

@budi

@budi budi commented May 30, 2019

Copy link
Copy Markdown
Contributor

Fix create_dataset to create table insde feast's dataset on BQ rather than creating an actual dataset in BQ (fix #201). Also change table_url from core and sdk to use full_table_id.

@budi
budi requested review from davidheryanto and pradithya May 30, 2019 05:32
@budi budi self-assigned this May 30, 2019
@feast-ci-bot

feast-ci-bot commented May 30, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: budi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto

davidheryanto commented May 31, 2019

Copy link
Copy Markdown
Collaborator

/hold
Until #209 is merged so we can unit test the python SDK too

@davidheryanto

davidheryanto commented May 31, 2019

Copy link
Copy Markdown
Collaborator

/test all

@davidheryanto

davidheryanto commented May 31, 2019

Copy link
Copy Markdown
Collaborator

/hold cancel

@davidheryanto

davidheryanto commented Jun 12, 2019

Copy link
Copy Markdown
Collaborator

/retest

@davidheryanto

davidheryanto commented Jun 12, 2019

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 3a29339 into feast-dev:master Jun 12, 2019
@feast-ci-bot

feast-ci-bot commented Jun 12, 2019

Copy link
Copy Markdown
Collaborator

@budi: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

Fix create_dataset to create table insde feast's dataset on BQ rather than creating an actual dataset in BQ (fix #201). Also change table_url from core and sdk to use full_table_id.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradithya pradithya Awaiting requested review from pradithya
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@thirteen37 thirteen37 Awaiting requested review from thirteen37
@tims tims Awaiting requested review from tims
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@budi budi

@davidheryanto davidheryanto

Labels

approved lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python SDK create_dataset is actually creating dataset in BQ

3 participants

@budi @feast-ci-bot @davidheryanto