Skip to content

Fixing broken entity key link in quickstart#2068

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
adchia:fixBrokenLink
Nov 23, 2021
Merged

Fixing broken entity key link in quickstart#2068
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
adchia:fixBrokenLink

Conversation

@adchia

@adchia adchia commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Fixes a broken link in the quickstart python notebook

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@adchia adchia requested review from a team, achals, felixwang9817, tsotnet and woop as code owners November 18, 2021 21:30
@codecov-commenter

codecov-commenter commented Nov 18, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2068 (44c24ee) into master (380cc62) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
- Coverage   83.59%   83.31%   -0.29%     
==========================================
  Files         100      100              
  Lines        8084     8084              
==========================================
- Hits         6758     6735      -23     
- Misses       1326     1349      +23
Flag Coverage Δ
integrationtests 73.74% <ø> (+0.02%) ⬆️
unittests 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/aws.py 72.59% <0.00%> (-11.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380cc62...44c24ee. Read the comment docs.

@feast-ci-bot

feast-ci-bot commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Nov 18, 2021

Copy link
Copy Markdown
Member

/lgtm

@achals

achals commented Nov 19, 2021

Copy link
Copy Markdown
Member

@adchia I think this needs to be rebased before it can get merged

@adchia
Fixing broken entity key link in quickstart
44c24ee 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label Nov 19, 2021
@achals

achals commented Nov 23, 2021

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot feast-ci-bot merged commit c239037 into feast-dev:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@achals achals Awaiting requested review from achals

@felixwang9817 felixwang9817 Awaiting requested review from felixwang9817

@tsotnet tsotnet Awaiting requested review from tsotnet

Assignees

@achals achals

@woop woop

Labels

approved kind/housekeeping lgtm release-note-none size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adchia @codecov-commenter @feast-ci-bot @woop @achals