Skip to content

Add detailed error messages for test_univerisal_e2e failures#2062

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
achals:achal/debug-test-universal-e2e
Nov 18, 2021
Merged

Add detailed error messages for test_univerisal_e2e failures#2062
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
achals:achal/debug-test-universal-e2e

Conversation

@achals
Copy link
Copy Markdown
Member

@achals achals commented Nov 18, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

There's some flakiness in this error and I can't figure out why - hoping that additional context will help debug.

Does this PR introduce a user-facing change?:

none

@achals
Add detailed error messages for test_univerisal_e2e failures
192eacb 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested review from a team, adchia, felixwang9817, tsotnet and woop as code owners November 18, 2021 06:28
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 18, 2021 •
edited
Loading

Codecov Report

Merging #2062 (192eacb) into master (8f370a0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2062   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files         100      100           
  Lines        8080     8080           
=======================================
  Hits         4706     4706           
  Misses       3374     3374
Flag Coverage Δ
unittests 58.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...python/tests/integration/e2e/test_universal_e2e.py 30.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f370a0...192eacb. Read the comment docs.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Copy Markdown
Collaborator

pyalex commented Nov 18, 2021

/lgtm

@achals
Copy link
Copy Markdown
Member Author

achals commented Nov 18, 2021

/kind housekeeping

@feast-ci-bot feast-ci-bot merged commit f5c1935 into feast-dev:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes

@adchia adchia Awaiting requested review from adchia

@felixwang9817 felixwang9817 Awaiting requested review from felixwang9817

@tsotnet tsotnet Awaiting requested review from tsotnet

@woop woop Awaiting requested review from woop

Assignees

@pyalex pyalex

@tsotnet tsotnet

Labels

approved kind/housekeeping lgtm release-note-none size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@achals @codecov-commenter @feast-ci-bot @pyalex @tsotnet