Fix unit test cli in prow script not returning correct exit code - #206
Conversation
Previously, after piping and calling tee, the return code is the return code of tee not the test command, which is not what we want
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit-test-cli |
|
@davidheryanto: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
NOTE: |
|
/lgtm |
Previously, when running unit test for CLI, the return code is the return code of the "tee" command NOT the "test" command. Hence it was always successful and we might miss failing Feast CLI unit tests.