Skip to content

Install redis extra in AWS Lambda feature server & add hiredis depend…#2057

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
tsotnet:tsotne/redis-lambda-fix
Nov 18, 2021
Merged

Install redis extra in AWS Lambda feature server & add hiredis depend…#2057
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
tsotnet:tsotne/redis-lambda-fix

Conversation

@tsotnet
Copy link
Copy Markdown
Collaborator

@tsotnet tsotnet commented Nov 17, 2021

…ency

What this PR does / why we need it:

  1. Re-introduce installing redis extra in AWS lambda-based feature server. This makes it possible to use public Redis endpoints with lambda (e.g. Redis Enterprise).
  2. Install hiredis library, which is a C-based client and allows the default redis client to perform better (https://github.com/redis/redis-py/blob/1a41cfd95a53a95b078084d8627be6b6fba3bb71/redis/utils.py#L4).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Allow using Redis online store in AWS Lambda feature server

@tsotnet tsotnet added the kind/feature New feature or request label Nov 17, 2021
@tsotnet tsotnet requested review from a team, achals, adchia and woop as code owners November 17, 2021 23:27
Install redis extra in AWS Lambda feature server & add hiredis depend…
9d8f1a8 
…ency

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@tsotnet tsotnet force-pushed the tsotne/redis-lambda-fix branch from 0033234 to 9d8f1a8 Compare November 17, 2021 23:28
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2021 •
edited
Loading

Codecov Report

Merging #2057 (0033234) into master (3bbd4cf) will increase coverage by 25.14%.
The diff coverage is n/a.

❗ Current head 0033234 differs from pull request most recent head 9d8f1a8. Consider uploading reports for the commit 9d8f1a8 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2057       +/-   ##
===========================================
+ Coverage   58.31%   83.46%   +25.14%     
===========================================
  Files         100      100               
  Lines        8066     8066               
===========================================
+ Hits         4704     6732     +2028     
+ Misses       3362     1334     -2028
Flag Coverage Δ
integrationtests 73.87% <ø> (?)
unittests 58.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 61.29% <0.00%> (+0.40%) ⬆️
sdk/python/feast/online_response.py 87.71% <0.00%> (+1.75%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 96.77% <0.00%> (+2.15%) ⬆️
sdk/python/feast/feature.py 72.72% <0.00%> (+3.03%) ⬆️
sdk/python/feast/infra/provider.py 91.73% <0.00%> (+4.95%) ⬆️
sdk/python/feast/errors.py 70.00% <0.00%> (+5.00%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 96.80% <0.00%> (+8.00%) ⬆️
sdk/python/feast/registry.py 80.76% <0.00%> (+10.48%) ⬆️
sdk/python/feast/feature_view.py 88.05% <0.00%> (+10.69%) ⬆️
sdk/python/feast/infra/passthrough_provider.py 100.00% <0.00%> (+11.11%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbd4cf...9d8f1a8. Read the comment docs.

adchia
adchia approved these changes Nov 17, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @DvirDukhan

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 214a916 into feast-dev:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

@felixwang9817 felixwang9817 Awaiting requested review from felixwang9817

@achals achals Awaiting requested review from achals

@woop woop Awaiting requested review from woop

Assignees

@adchia adchia

Labels

approved kind/feature New feature or request lgtm ok-to-test release-note size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tsotnet @codecov-commenter @feast-ci-bot @adchia