Skip to content

Correct cleanup after usage e2e tests - #2015

Merged
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
pyalex:fix-usage-test
Nov 10, 2021
Merged

Correct cleanup after usage e2e tests#2015
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
pyalex:fix-usage-test

Conversation

@pyalex

@pyalex pyalex commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

This PR fixes flaky e2e tests for usage module.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pyalex
Correct cleanup after usage e2e tests
9a41e73 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex
do not override is_enabled directly
aa6f27f 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@codecov-commenter

codecov-commenter commented Nov 9, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2015 (7dabb85) into master (3ee88f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2015   +/-   ##
=======================================
  Coverage   83.21%   83.22%           
=======================================
  Files         103      103           
  Lines        8417     8421    +4     
=======================================
+ Hits         7004     7008    +4     
  Misses       1413     1413
Flag Coverage Δ
integrationtests 74.38% <100.00%> (+0.01%) ⬆️
unittests 60.34% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/integration/e2e/test_usage_e2e.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee88f4...7dabb85. Read the comment docs.

felixwang9817
felixwang9817 approved these changes Nov 9, 2021
View reviewed changes

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817

felixwang9817 commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

/kind bug

@pyalex
reload modules after test
7dabb85 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Nov 10, 2021
@felixwang9817

felixwang9817 commented Nov 10, 2021

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 06b1f37 into feast-dev:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes
@achals achals Awaiting requested review from achals
@adchia adchia Awaiting requested review from adchia
@tsotnet tsotnet Awaiting requested review from tsotnet
@woop woop Awaiting requested review from woop

Assignees

@tsotnet tsotnet

@felixwang9817 felixwang9817

Labels

approved kind/bug lgtm release-note-none size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pyalex @codecov-commenter @feast-ci-bot @felixwang9817 @tsotnet