Skip to content

Set a 5 minute limit for redshift statement execution#1915

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/stop-after-delay
Sep 30, 2021
Merged

Set a 5 minute limit for redshift statement execution#1915
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/stop-after-delay

Conversation

@achals

@achals achals commented Sep 30, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1841

Does this PR introduce a user-facing change?:

Sets a 5 minute limit for redshift statement execution.

@achals
Set a 5 minute limit for redshift statement execution
6c9ddcf 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter

codecov-commenter commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1915 (6c9ddcf) into master (ce5a130) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
+ Coverage   82.85%   82.95%   +0.10%     
==========================================
  Files          96       96              
  Lines        7360     7359       -1     
==========================================
+ Hits         6098     6105       +7     
+ Misses       1262     1254       -8
Flag Coverage Δ
integrationtests 74.38% <100.00%> (-0.24%) ⬇️
unittests 60.76% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/utils/aws_utils.py 83.03% <100.00%> (-0.90%) ⬇️
sdk/python/feast/importer.py 64.28% <0.00%> (-9.40%) ⬇️
sdk/python/feast/feature_service.py 75.34% <0.00%> (-1.29%) ⬇️
sdk/python/feast/entity.py 73.60% <0.00%> (-1.21%) ⬇️
sdk/python/feast/feature_table.py 44.89% <0.00%> (-0.38%) ⬇️
sdk/python/feast/feature_view.py 86.57% <0.00%> (-0.36%) ⬇️
sdk/python/feast/on_demand_feature_view.py 89.47% <0.00%> (-0.19%) ⬇️
sdk/python/tests/unit/test_entity.py 100.00% <0.00%> (ø)
...ion/test_cli_apply_duplicated_featureview_names.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5a130...6c9ddcf. Read the comment docs.

felixwang9817
felixwang9817 approved these changes Sep 30, 2021
View reviewed changes

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Sep 30, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 189ffb0 into feast-dev:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

@adchia adchia Awaiting requested review from adchia

@tsotnet tsotnet Awaiting requested review from tsotnet

@woop woop Awaiting requested review from woop

Assignees

@felixwang9817 felixwang9817

Labels

approved kind/bug lgtm release-note size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redshift does not exit long running query

4 participants

@achals @codecov-commenter @feast-ci-bot @felixwang9817