Skip to content

Cleanup tests - #1901

Merged
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
felixwang9817:cleanup_tests
Sep 23, 2021
Merged

Cleanup tests#1901
feast-ci-bot merged 5 commits into
feast-dev:masterfrom
felixwang9817:cleanup_tests

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: The universal test suite refactor made several old tests redundant. This PR removes redundant tests in test_historical_retrieval.py.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817
Remove infer_event_timestamp_col
a5de3d0 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Remove unnecessary historical retrieval test
6ba109d 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Remove more unnecessary tests
c07bfa5 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Move test from integration to unit
dfab5c1 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
achals
achals approved these changes Sep 23, 2021
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Rename test file to avoid pytest conflicts
d7ed40e 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Sep 23, 2021
@feast-ci-bot

feast-ci-bot commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@felixwang9817

felixwang9817 commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator Author

/kind housekeeping

@codecov-commenter

codecov-commenter commented Sep 23, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1901 (d7ed40e) into master (09f525c) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
- Coverage   83.31%   82.97%   -0.35%     
==========================================
  Files          96       96              
  Lines        7482     7306     -176     
==========================================
- Hits         6234     6062     -172     
+ Misses       1248     1244       -4
Flag Coverage Δ
integrationtests 74.71% <42.85%> (+0.51%) ⬆️
unittests 60.49% <85.71%> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 100.00% <ø> (ø)
sdk/python/feast/driver_test_data.py 100.00% <100.00%> (ø)
sdk/python/tests/unit/test_feature_validation.py 100.00% <100.00%> (ø)
sdk/python/feast/feature.py 72.72% <0.00%> (-1.52%) ⬇️
...python/feast/infra/offline_stores/offline_utils.py 90.10% <0.00%> (-1.10%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 83.92% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f525c...d7ed40e. Read the comment docs.

@achals achals added the lgtm label Sep 23, 2021
@feast-ci-bot
feast-ci-bot merged commit dcae160 into feast-dev:master Sep 23, 2021
@felixwang9817
felixwang9817 deleted the cleanup_tests branch September 23, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes
@adchia adchia Awaiting requested review from adchia
@tsotnet tsotnet Awaiting requested review from tsotnet
@woop woop Awaiting requested review from woop

Assignees

@achals achals

Labels

approved kind/housekeeping lgtm release-note-none size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixwang9817 @feast-ci-bot @codecov-commenter @achals