Skip to content

Fix list feature format for BigQuery offline datasources. #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 7 commits into from
Sep 21, 2021
Merged

Fix list feature format for BigQuery offline datasources. #1889

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fdf5722
Enable test for list features in BQ
judahrand Sep 20, 2021
268075e
Remove specifc handling of BQ list types
judahrand Sep 20, 2021
6279b9d
Enable Parquet list inference for BigQuery
judahrand Sep 20, 2021
5d35ec5
Enable `use_compliant_nested_type`
judahrand Sep 20, 2021
81c8abc
Add potentially missing import
judahrand Sep 20, 2021
db6f607
Upload all data to BQ in ARRAY safe manner
judahrand Sep 20, 2021
f90aa17
Handle empty list in `python_value_to_proto_value`
judahrand Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove specifc handling of BQ list types 
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
  • Loading branch information
@judahrand
judahrand committed Sep 20, 2021
commit 268075e0bbe8fb76f870500ca91f4eb51ba697ae
30 changes: 8 additions & 22 deletions sdk/python/tests/integration/registration/test_universal_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,16 +248,10 @@ def assert_feature_list_types(
"bool": "bool",
}
assert str(historical_features_df.dtypes["value"]) == "object"
if provider == "gcp":
assert (
feature_list_dtype_to_expected_historical_feature_list_dtype[feature_dtype]
in type(historical_features_df.value[0]["list"][0]["item"]).__name__
)
else:
assert (
feature_list_dtype_to_expected_historical_feature_list_dtype[feature_dtype]
in type(historical_features_df.value[0][0]).__name__
)
assert (
Comment thread
judahrand marked this conversation as resolved.
Outdated
feature_list_dtype_to_expected_historical_feature_list_dtype[feature_dtype]
in type(historical_features_df.value[0][0]).__name__
)


def assert_expected_arrow_types(
Expand All @@ -280,18 +274,10 @@ def assert_expected_arrow_types(
feature_dtype
]
if feature_is_list:
if provider == "gcp":
assert str(
historical_features_arrow.schema.field_by_name("value").type
) in [
f"struct<list: list<item: struct<item: {arrow_type}>> not null>",
f"struct<list: list<item: struct<item: {arrow_type}>>>",
]
else:
assert (
str(historical_features_arrow.schema.field_by_name("value").type)
== f"list<item: {arrow_type}>"
)
assert (
str(historical_features_arrow.schema.field_by_name("value").type)
== f"list<item: {arrow_type}>"
)
else:
assert (
str(historical_features_arrow.schema.field_by_name("value").type)
Expand Down