Skip to content

Fix BigQuery query template to retrieve training data - #182

Merged
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
davidheryanto:dataset-service-fix
Apr 18, 2019
Merged

Fix BigQuery query template to retrieve training data#182
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
davidheryanto:dataset-service-fix

Conversation

@davidheryanto

@davidheryanto davidheryanto commented Apr 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Previous BigQuery query template used by DatasetService to retrieve training data has some errors for e.g. it creates query like

# mygcpproject.mydataset.mycolumn is not a valid column name
SELECT mygcpproject.mydataset.mycolumn FROM mygcpproject.mydataset.mycolumn LIMIT 5

This is a fix to the templates.

Extra notes

How to reproduce this error using Feast Python SDK which will call the DatasetService:

Assuming you have ingested feature: myentity.myfeature with event timestamp between 2019-01-01 and 2019-01-02

# Import details are ommitted
# ...

feature_set = FeatureSet(entity="myentity", 
                         features=["myentity.myfeature"])
dataset_info = feast_client.create_dataset(feature_set, "2019-01-01", "2019-01-02")
dataset = fs.download_dataset_to_df(dataset_info, staging_location="gs://mybucket")

@zhilingc

zhilingc commented Apr 17, 2019

Copy link
Copy Markdown
Collaborator

/lgtm

tims
tims reviewed Apr 17, 2019
View reviewed changes
Comment thread core/src/main/java/feast/core/training/BigQueryDatasetTemplater.java Outdated
@feast-ci-bot feast-ci-bot removed the lgtm label Apr 18, 2019
@pradithya

pradithya commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

/approve

@feast-ci-bot

feast-ci-bot commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc

zhilingc commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot
feast-ci-bot merged commit aeb12cd into feast-dev:master Apr 18, 2019
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Jan 25, 2026
@konflux-internal-p02 @aniketpalu
chore(deps): update konflux references (feast-dev#182)
be44a04 
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Mar 2, 2026
@konflux-internal-p02
chore(deps): update konflux references (feast-dev#182)
2b085d6 
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Mar 2, 2026
@konflux-internal-p02 @aniketpalu
chore(deps): update konflux references (feast-dev#182)
4dde8bc 
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradithya pradithya Awaiting requested review from pradithya
@zhilingc zhilingc Awaiting requested review from zhilingc
1 more reviewer
@tims tims tims left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@zhilingc zhilingc

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidheryanto @zhilingc @pradithya @feast-ci-bot @tims