Change internal references from input to batch_source - #1729
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1729 +/- ##
=======================================
Coverage 79.06% 79.07%
=======================================
Files 80 80
Lines 6849 6852 +3
=======================================
+ Hits 5415 5418 +3
Misses 1434 1434
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
711dfc8 to
03f557e
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
03f557e to
7713a9a
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| tags: Optional[Dict[str, str]] = None, | ||
| online: bool = True, | ||
| ): | ||
| warnings.warn( |
There was a problem hiding this comment.
@felixwang9817 Should we warn users only when the input is assigned ?
There was a problem hiding this comment.
@tedhtchang That's a good point, I think ideally we would have done that. However, given that (a) input was a required parameter before this change, so almost all users will continue to use input, and (b) releases are fairly frequent so this deprecation warning will soon become outdated, I think we can leave this change as is.
There was a problem hiding this comment.
@tedhtchang btw, I managed to insert this change into a separate PR (#1746). Thanks for pointing this one out!
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: FeatureViews have always required a batch data source as input; this argument is currently named
input. We recently introduced stream sources here, so now we have three arguments: a requiredinput, an optionalbatch_source, and an optionalstream_source. We should removeinputas an argument, makebatch_sourcerequired, and leavestream_sourceoptional; this is a breaking change, so we prepare for it by adding a deprecation warning. We also change internal references and docs to usebatch_sourceinstead ofinput, to point people in the right direction.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: