Registry teardown - #1718
Merged
Merged
Conversation
felixwang9817
requested review from
a team,
achals,
tsotnet and
woop
as code owners
July 17, 2021 00:06
Codecov Report
@@ Coverage Diff @@
## master #1718 +/- ##
==========================================
+ Coverage 78.66% 78.80% +0.13%
==========================================
Files 77 77
Lines 6502 6529 +27
==========================================
+ Hits 5115 5145 +30
+ Misses 1387 1384 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
Author
|
/retest |
achals
approved these changes
Jul 17, 2021
woop
reviewed
Jul 19, 2021
woop
reviewed
Jul 19, 2021
felixwang9817
force-pushed
the
registry_teardown
branch
from
July 21, 2021 00:57
d9a3b9d to
ab32c3f
Compare
felixwang9817
force-pushed
the
registry_teardown
branch
from
July 21, 2021 17:55
ab32c3f to
e9ef726
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
force-pushed
the
registry_teardown
branch
from
July 22, 2021 00:39
e9ef726 to
92c66c6
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As of right now, registries do not get cleaned up during teardown. This is especially bad for GCS and S3 registries. This PR ensures that registries get cleaned up during teardown.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: