Skip to content

Allow specifying FeatureServices in FeatureStore methods#1691

Merged
feast-ci-bot merged 58 commits intofeast-dev:masterfrom
achals:achal/feature-service-api
Jul 22, 2021
Merged

Allow specifying FeatureServices in FeatureStore methods#1691
feast-ci-bot merged 58 commits intofeast-dev:masterfrom
achals:achal/feature-service-api

Conversation

@achals
Copy link
Copy Markdown
Member

@achals achals commented Jul 6, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

FeatureServices only contain references to Features in FeatureViews. This PR allows them to be consumed in the get_historical_features and online_read methods.

Which issue(s) this PR fixes:

Part 2 for #1572

Does this PR introduce a user-facing change?:

NONE

@achals achals requested review from a team, tsotnet and woop as code owners July 6, 2021 17:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #1691 (03d0ba5) into master (5c7c240) will decrease coverage by 0.07%.
The diff coverage is 69.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   78.77%   78.69%   -0.08%     
==========================================
  Files          77       80       +3     
  Lines        6529     6765     +236     
==========================================
+ Hits         5143     5324     +181     
- Misses       1386     1441      +55
Flag Coverage Δ
integrationtests 78.62% <69.76%> (-0.07%) ⬇️
unittests 62.20% <50.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...alization/test_offline_online_store_consistency.py 100.00% <ø> (ø)
...n/tests/integration/online_store/test_e2e_local.py 100.00% <ø> (ø)
.../integration/online_store/test_online_retrieval.py 100.00% <ø> (ø)
sdk/python/feast/repo_operations.py 31.33% <16.66%> (-1.17%) ⬇️
sdk/python/feast/cli.py 43.67% <30.00%> (-2.85%) ⬇️
sdk/python/feast/errors.py 70.78% <40.00%> (-1.84%) ⬇️
sdk/python/feast/feature_service.py 71.21% <47.82%> (ø)
sdk/python/feast/registry.py 79.34% <74.19%> (-0.53%) ⬇️
sdk/python/feast/feature.py 75.00% <75.00%> (+3.33%) ⬆️
sdk/python/feast/feature_store.py 93.50% <88.63%> (-1.22%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7c240...03d0ba5. Read the comment docs.

@achals achals added the kind/feature New feature or request label Jul 6, 2021
woop
woop reviewed Jul 6, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
woop
woop reviewed Jul 6, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Jul 6, 2021
woop
woop reviewed Jul 7, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
woop
woop reviewed Jul 7, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
woop
woop reviewed Jul 7, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
woop
woop reviewed Jul 7, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
woop
woop reviewed Jul 7, 2021
View reviewed changes
Comment thread sdk/python/feast/feature_store.py Outdated
woop
woop reviewed Jul 7, 2021
View reviewed changes
Comment thread sdk/python/tests/online_read_write_test.py Outdated
achals added 8 commits July 7, 2021 13:14
@achals
Allow specifying FeatureServices in FeatureStore methods
f1fd9b8 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
format and lint
27ea33e 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
features_refs -> features
7ae1ed3 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
remote type: ignores
6269200 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
implement applying and persisting feature services into registry
8574163 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Fix integration test references
dbe2995 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Add backwards compatibility
7efd3c3 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
More lint
3e54197 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
lint
ac211d2 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Copy link
Copy Markdown
Member Author

achals commented Jul 19, 2021

Are we testing feature services for historical retrieval anywhere?

Good catch, added

achals added 4 commits July 19, 2021 14:21
@achals
format and tests
23c0d80 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
remove unused imports
798df64 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix registry
81fb228 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix docs
21aa6b6 
Signed-off-by: Achal Shah <achals@gmail.com>
woop
woop reviewed Jul 19, 2021
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/file.py Outdated
achals added 3 commits July 19, 2021 17:08
@achals
fix dangling print
a6ecc6d 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
make format and lint
54c95ae 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
list feature servces
2394f0a 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from woop July 22, 2021 19:15
achals added 4 commits July 22, 2021 12:16
@achals
Merge branch 'master' into achal/feature-service-api
2d11ab4
@achals
Merge from master
1ed9592
@achals
fix tests
2a48ae8 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Remove unused file
0943faf 
Signed-off-by: Achal Shah <achals@gmail.com>
woop
woop reviewed Jul 22, 2021
View reviewed changes
Comment thread docs/concepts/feature-service.md Outdated
@woop
Copy link
Copy Markdown
Member

woop commented Jul 22, 2021

/lgtm

@achals
single heading
03d0ba5 
Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Jul 22, 2021
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jul 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Jul 22, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 7dff49a into feast-dev:master Jul 22, 2021
@achals achals deleted the achal/feature-service-api branch July 22, 2021 20:06
@felixwang9817 felixwang9817 mentioned this pull request Jul 29, 2021
Merged
@achals achals linked an issue Aug 3, 2021 that may be closed by this pull request
Introduce Feature Services #1572
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@tsotnet tsotnet Awaiting requested review from tsotnet

Assignees

@woop woop

Labels

approved kind/feature New feature or request lgtm release-note-none size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce Feature Services

5 participants

@achals @codecov-commenter @woop @feast-ci-bot @tsotnet