Skip to content

BQ exception should be raised first before we check the timedout #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Jul 5, 2021
Merged

BQ exception should be raised first before we check the timedout #1675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
BQ exception should be raised first before we check the timedout 
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
  • Loading branch information
Matt Delacour committed Jun 30, 2021
commit 3aa4ad64bc612f33755dc36d07cb9cf37a2b492a
6 changes: 3 additions & 3 deletions sdk/python/feast/infra/offline_stores/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,13 +286,13 @@ def _wait_until_done(job_id):
job_id = bq_job.job_id
_wait_until_done(job_id=job_id)

if bq_job.exception():
raise bq_job.exception()

if not _is_done(job_id):
client.cancel_job(job_id)
raise BigQueryJobCancelled(job_id=job_id)

if bq_job.exception():
raise bq_job.exception()


@dataclass(frozen=True)
class FeatureViewQueryContext:
Expand Down