Skip to content

Add to_table() to RetrievalJob object #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Jun 29, 2021
Merged

Add to_table() to RetrievalJob object #1663

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9df3864
Add notion of OfflineJob
Jun 22, 2021
fa5551b
Use RetrievalJob instead of creating a new OfflineJob object
Jun 28, 2021
c378307
Add to_table() in integration tests
Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add to_table() in integration tests 
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
  • Loading branch information
Matt Delacour committed Jun 29, 2021
commit c378307c384f1e0ecec39f768329411e7ec19be7
9 changes: 9 additions & 0 deletions sdk/python/tests/test_historical_retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,11 @@ def test_historical_features_from_bigquery_sources(
check_dtype=False,
)

table_from_sql_entities = job_from_sql.to_table()
assert_frame_equal(
actual_df_from_sql_entities, table_from_sql_entities.to_pandas()
)

timestamp_column = (
"e_ts"
if infer_event_timestamp_col
Expand Down Expand Up @@ -541,3 +546,7 @@ def test_historical_features_from_bigquery_sources(
.reset_index(drop=True),
check_dtype=False,
)
table_from_df_entities = job_from_df.to_table()
assert_frame_equal(
actual_df_from_df_entities, table_from_df_entities.to_pandas()
)