Add methods to offline/online stores to specify supported upstream sources#1662
Add methods to offline/online stores to specify supported upstream sources#1662achals wants to merge 2 commits intofeast-dev:masterfrom
Conversation
…urces Signed-off-by: Achal Shah <achals@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah <achals@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
===========================================
- Coverage 84.05% 71.97% -12.09%
===========================================
Files 72 71 -1
Lines 6273 6247 -26
===========================================
- Hits 5273 4496 -777
- Misses 1000 1751 +751
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @abstractmethod | ||
| def supports_offline_store(self, offline_store: Any) -> bool: | ||
| ... | ||
|
|
There was a problem hiding this comment.
Why does online store need to define which offline stores to support? The online store and offline store do no interact with each other directly.
I'd say let providers define which online store & offline store they support.
There was a problem hiding this comment.
Why does online store need to define which offline stores to support? The online store and offline store do no interact with each other directly.
I'd say let providers define which online store & offline store they support.
Spoke offline - I'm going to scrap this PR because there's no explicitly unsupported combination at the moment. We should wait until the need for this kind of API emerges, possibly after we have an AWS provider.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
We need a way for Online and Offline stores to be explicit about what upstream sources are supported. This was added in #1552 but removed in #1649. This PR adds it back in.
Does this PR introduce a user-facing change?: