Skip to content

Provide the user with more options for setting the to_bigquery config #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 5 commits into from
Jun 28, 2021
Merged

Provide the user with more options for setting the to_bigquery config #1661

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccc59f8
Provide more options for to_bigquery config
Jun 22, 2021
30b7b32
Fix default job_config when none; remove excessive testing
Jun 23, 2021
0b5f6ed
Add param type and docstring
Jun 24, 2021
e87dad0
add docstrings and typing
Jun 24, 2021
e6faf27
Apply docstring suggestions from code review
codyjlin Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add docstrings and typing 
Signed-off-by: Cody Lin <codyl@twitter.com>
  • Loading branch information
Cody Lin committed Jun 24, 2021
commit e87dad093fefff98eb33110659d942531d2b2676
7 changes: 5 additions & 2 deletions sdk/python/feast/infra/offline_stores/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,15 @@ def to_df(self):
df = self.client.query(self.query).to_dataframe(create_bqstorage_client=True)
return df

def to_sql(self):
def to_sql(self) -> str:
"""
Returns the SQL query that can be modified and run by the user to create the BQ table.
Comment thread
codyjlin marked this conversation as resolved.
Outdated
"""
return self.query

def to_bigquery(self, job_config: bigquery.QueryJobConfig = None) -> Optional[str]:
"""
Uploads the results of the BigQueryRetrievalJob directly to BigQuery
Uploads the results of the BigQueryRetrievalJob directly to BigQuery.
Comment thread
codyjlin marked this conversation as resolved.
Outdated

Args:
job_config: A bigquery.QueryJobConfig to specify options like destination table, dry run, etc.
Comment thread
codyjlin marked this conversation as resolved.
Outdated
Expand Down