Skip to content

Refactor OnlineStoreConfig classes into owning modules #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Jun 21, 2021
Merged

Refactor OnlineStoreConfig classes into owning modules #1649

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe441c1
Refactor OnlineStoreConfig classes into owning modules
achals Jun 15, 2021
f79a3b9
make format
achals Jun 15, 2021
587b981
Move redis too
achals Jun 16, 2021
b9bc19b
update test_telemetery
achals Jun 16, 2021
37b5dd8
add a create_repo_config method that should be called instead of Repo…
achals Jun 16, 2021
fa5fd81
fix the table reference in repo_operations
achals Jun 16, 2021
32dce48
reuse create_repo_config
achals Jun 16, 2021
1060170
CR comments
achals Jun 17, 2021
39be498
Remove create_repo_config in favor of __init__
achals Jun 17, 2021
25c9a45
make format
achals Jun 17, 2021
3ee9185
Remove print statement
achals Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test_telemetery 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Jun 16, 2021
commit b9bc19b81be3a934945d55a363a6790cb3ae9dbc
4 changes: 2 additions & 2 deletions sdk/python/telemetry_tests/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
import uuid
from datetime import datetime

from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig
from tenacity import retry, wait_exponential, stop_after_attempt

from google.cloud import bigquery
import os
from time import sleep
from importlib import reload

from feast import Client, Entity, ValueType, FeatureStore, RepoConfig
from feast.repo_config import SqliteOnlineStoreConfig


TELEMETRY_BIGQUERY_TABLE = (
"kf-feast.feast_telemetry.cloudfunctions_googleapis_com_cloud_functions"
Expand Down