Add assertions for supported sources for known online stores#1648
Add assertions for supported sources for known online stores#1648achals wants to merge 2 commits intofeast-dev:masterfrom
Conversation
Signed-off-by: Achal Shah <achals@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
+ Coverage 83.39% 83.46% +0.06%
==========================================
Files 71 71
Lines 6113 6144 +31
==========================================
+ Hits 5098 5128 +30
- Misses 1015 1016 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <achals@gmail.com>
|
@achals: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this in favor of #1649 |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Adds some assertions, and fixes some minor bugs with prints and removes a dangling reference to the redis provider.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: