Skip to content

Provide descriptive error on invalid table reference #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 20 commits into from
Jun 21, 2021
Merged

Provide descriptive error on invalid table reference #1627

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1a91a33
Initial commit to catch nonexistent table
Jun 7, 2021
da7a712
simplify nonexistent BQ table test
Jun 8, 2021
f6a2f98
clean up table_exists exception
Jun 8, 2021
41e69a7
remove unneeded variable
Jun 8, 2021
af937c4
function name change to _assert_table_exists
Jun 8, 2021
215de4b
Initial commit to catch nonexistent table
Jun 7, 2021
caac9d0
simplify nonexistent BQ table test
Jun 8, 2021
2d2a484
clean up table_exists exception
Jun 8, 2021
c548ab6
function name change to _assert_table_exists
Jun 8, 2021
d5eb8af
fix lint errors and rebase
Jun 9, 2021
21a7631
Fix get_table(None) error
Jun 9, 2021
50831ef
custom exception for both missing file and BQ source
Jun 9, 2021
4e7a803
revert FileSource checks
Jun 10, 2021
2d99b05
Use DataSourceNotFoundException instead of subclassing
Jun 11, 2021
c513660
Moved assert_table_exists out of the BQ constructor to apply_total
Jun 14, 2021
617dde1
rename test and test asset
Jun 16, 2021
6b3975a
move validate logic back to data_source
Jun 17, 2021
458beab
fixed tests
Jun 19, 2021
5abc428
Set pytest.integration for tests that access BQ
Jun 20, 2021
4ec510d
Import pytest in failed test files
Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed tests 
Signed-off-by: Cody Lin <codyl@twitter.com>
  • Loading branch information
Cody Lin committed Jun 19, 2021
commit 458beab6945ec140b08bd5bfd668329d03869df9
34 changes: 0 additions & 34 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,40 +526,6 @@ def validate(self):
"""
raise NotImplementedError

def _infer_event_timestamp_column(self, ts_column_type_regex_pattern):
ERROR_MSG_PREFIX = "Unable to infer DataSource event_timestamp_column"
USER_GUIDANCE = "Please specify event_timestamp_column explicitly."

if isinstance(self, FileSource) or isinstance(self, BigQuerySource):
event_timestamp_column, matched_flag = None, False
for col_name, col_datatype in self.get_table_column_names_and_types():
if re.match(ts_column_type_regex_pattern, col_datatype):
if matched_flag:
raise TypeError(
f"""
{ERROR_MSG_PREFIX} due to multiple possible columns satisfying
the criteria. {USER_GUIDANCE}
"""
)
matched_flag = True
event_timestamp_column = col_name
if matched_flag:
return event_timestamp_column
else:
raise TypeError(
f"""
{ERROR_MSG_PREFIX} due to an absence of columns that satisfy the criteria.
{USER_GUIDANCE}
"""
)
else:
raise TypeError(
f"""
{ERROR_MSG_PREFIX} because this DataSource currently does not support this inference.
{USER_GUIDANCE}
"""
)


class FileSource(DataSource):
def __init__(
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/repo_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,11 @@ def apply_total(repo_config: RepoConfig, repo_path: Path):
assert_offline_store_supports_data_source(
repo_config.offline_store, data_source
)
data_source.validate()

update_data_sources_with_inferred_event_timestamp_col(data_sources)
for view in repo.feature_views:
view.infer_features_from_input_source()
data_source.validate()

tables_to_delete = []
for registry_table in registry.list_feature_tables(project=project):
Expand Down