Simplify and document CLI building steps - #158
Merged
Merged
Conversation
Building the CLI is now two steps to install dev dependencies and one step to build.
Contributor
|
@woop didn't you want to rewrite this in python? |
Contributor
|
/lgtm |
Member
Correct. I think rewriting this in Python would make a lot of sense. So it can be seen as a tech debt, but it's not a high priority right now. I think our focus should be more on hygiene (docs, tests, packaging). |
Member
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Srihari1192
pushed a commit
to Srihari1192/feast
that referenced
this pull request
Jul 27, 2026
…ev#158) * feat: add upstream and downstream cherry-pick sync workflows Extend the label-based cherry-pick automation beyond stable: - sync_upstream.yml: on `sync-to-upstream` label, creates cross-repo PR against feast-dev/feast master - sync_downstream_branch.yml: on `sync-to-rhoai-*` labels, creates PRs against downstream release branches (e.g., rhoai-3.5, rhoai-3.4-ea.1) Co-authored-by: Cursor <cursoragent@cursor.com> * fix: address coderabbitai review feedback on sync workflows - Add persist-credentials: false on checkout to limit PAT scope - Add least-privilege permissions (contents: read) to detect-targets job - Move event-derived values into env: vars to prevent template injection - Reorder branch-existence check before git fetch (was unreachable) - Fix doc inconsistency between label table and usage examples Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com> --------- Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to reduce the complexity of getting the development dependencies necessary for building the CLI and update the README with these new steps.