Entity value_type inference for Feature Repo registration by mavysavydav · Pull Request #1538 · feast-dev/feast

mavysavydav · 2021-05-06T17:18:31Z

Signed-off-by: David Y Liu davidyliuliu@gmail.com

What this PR does / why we need it:
This change enables users to register Entities without needing to specify the value_type because we'll be able to infer it based on finding the entity column in the table based on the Entity name and using that type. Milestone 2 of this RFC.

Which issue(s) this PR fixes:

Fixes #1500

Does this PR introduce a user-facing change?:

This change enables users to register Entities without needing to specify the value_type because we'll be able to infer it based on finding the entity column in the table based on the Entity name and using that type.  More details can be found in this doc as milestone 2 -- https://docs.google.com/document/d/1MkWvexE4e5nYWcQLELFnJ5o9OlJDKC2rn_USHMDT9dg/edit#heading=h.pqhio4s5uw2s.

feast-ci-bot · 2021-05-06T17:18:41Z

Hi @mavysavydav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jklegar · 2021-05-10T16:07:35Z

/ok-to-test

jklegar · 2021-05-10T16:07:40Z

/kind feature

jklegar

Thanks @mavysavydav this looks great! The one thing I see is that there's also a way to apply a specific set of entities/feature views on the FeatureStore class here:

feast/sdk/python/feast/feature_store.py

Line 179 in 8712826

def apply(

Note it's an "incremental apply" rather than a "total apply" so only the new/to-be-updated entities/feature views are passed in.
Would you be able to add entity inference in there as well?

mavysavydav · 2021-05-18T17:51:58Z

Sounds good, will take a look

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

…code Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

codecov-commenter · 2021-05-25T21:43:04Z

Codecov Report

Merging #1538 (6dc6104) into master (dfb029d) will increase coverage by 0.06%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
+ Coverage   83.59%   83.65%   +0.06%     
==========================================
  Files          65       67       +2     
  Lines        5753     5812      +59     
==========================================
+ Hits         4809     4862      +53     
- Misses        944      950       +6

Flag	Coverage Δ
integrationtests	`83.56% <95.83%> (+0.06%)`	⬆️
unittests	`77.85% <87.50%> (+0.49%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/entity.py	`96.36% <ø> (ø)`
sdk/python/tests/utils/data_source_utils.py	`100.00% <ø> (ø)`
sdk/python/feast/repo_operations.py	`32.17% <50.00%> (+0.17%)`	⬆️
sdk/python/feast/feature_store.py	`91.85% <88.88%> (-0.04%)`	⬇️
sdk/python/feast/inference.py	`95.45% <95.45%> (ø)`
sdk/python/tests/conftest.py	`100.00% <100.00%> (ø)`
sdk/python/tests/test_feature_store.py	`100.00% <100.00%> (ø)`
sdk/python/tests/test_inference.py	`100.00% <100.00%> (ø)`
sdk/python/feast/telemetry.py	`61.53% <0.00%> (-1.09%)`	⬇️
sdk/python/feast/data_source.py	`78.77% <0.00%> (-0.07%)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb029d...6dc6104. Read the comment docs.

mavysavydav · 2021-05-25T22:06:10Z

Ready for another round of review. Sorry for the mess in this PR. Accidentally messed up my branch when syncing w master

woop · 2021-05-25T23:08:43Z

Ready for another round of review. Sorry for the mess in this PR. Accidentally messed up my branch when syncing w master

Thanks @mavysavydav

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

mavysavydav · 2021-05-26T04:53:46Z

btw I made the assumption that for featurestore.apply, we'd only want to infer the entities based on the feature_views passed in as part of that apply call. The reason I thought this was reasonable is that the alternative suggests a feature_view has been applied with an entity that hasn't been defined yet. Though in the case of redefinitions of entities, inferring from previously applied FeatureViews seems like ok behavior but that won't be done with the current logic. Happy to reconsider if ppl disagree.

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

woop · 2021-06-02T18:50:04Z

/lgtm

feast-ci-bot · 2021-06-02T18:50:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mavysavydav, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Added inferencing of Entity values types & corresponding test Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Updated example_feature_repo_with_inference.py Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Fixed lint issue introduced by previous commit Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Optimized infer_entity_value_type_from_feature_views Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Added entity data type inferencing to feature_store.py and organized code Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Made error messages more descriptive and improved its structuring Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Removed s comments by using conftest file Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Renamed variables for clarity and added clarifying comments Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * changed file name from inference_helpers.py to inference.py Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

mavysavydav requested review from a team, jklegar, tsotnet and woop as code owners May 6, 2021 17:18

feast-ci-bot added release-note needs-kind labels May 6, 2021

feast-ci-bot added needs-ok-to-test size/L labels May 6, 2021

mavysavydav force-pushed the entityValueTypeInference branch from 5681099 to 1c52ba2 Compare May 6, 2021 17:19

jklegar self-assigned this May 6, 2021

mavysavydav force-pushed the entityValueTypeInference branch from f604d9d to 1af0ae8 Compare May 7, 2021 07:14

feast-ci-bot added ok-to-test kind/feature New feature or request and removed needs-ok-to-test needs-kind labels May 10, 2021

jklegar reviewed May 10, 2021

View reviewed changes

Comment thread sdk/python/feast/repo_operations.py Outdated

woop reviewed May 19, 2021

View reviewed changes

Comment thread sdk/python/tests/test_repo_operations.py Outdated

woop reviewed May 19, 2021

View reviewed changes

Comment thread sdk/python/tests/test_repo_operations.py Outdated

woop reviewed May 19, 2021

View reviewed changes

Comment thread sdk/python/feast/repo_operations.py Outdated

mavysavydav added 5 commits May 24, 2021 14:40

Added inferencing of Entity values types & corresponding test

7a487dc

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

Updated example_feature_repo_with_inference.py

6d58084

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

Fixed lint issue introduced by previous commit

307fae1

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

Optimized infer_entity_value_type_from_feature_views

697304d

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

Added entity data type inferencing to feature_store.py and organized …

3bb9524

…code Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

feast-ci-bot added size/XXL and removed size/L labels May 25, 2021

mavysavydav force-pushed the entityValueTypeInference branch from d25e11c to 3bb9524 Compare May 25, 2021 21:48

feast-ci-bot added size/L and removed size/XXL labels May 25, 2021

Made error messages more descriptive and improved its structuring

25dae14

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

Removed s comments by using conftest file

9e99e90

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

mavysavydav force-pushed the entityValueTypeInference branch from fc7fd72 to 9e99e90 Compare June 2, 2021 06:16

woop reviewed Jun 2, 2021

View reviewed changes

Comment thread sdk/python/feast/inference_helpers.py

woop reviewed Jun 2, 2021

View reviewed changes

Comment thread sdk/python/feast/inference_helpers.py Outdated

woop reviewed Jun 2, 2021

View reviewed changes

Comment thread sdk/python/feast/inference_helpers.py Outdated

woop reviewed Jun 2, 2021

View reviewed changes

Comment thread sdk/python/feast/inference_helpers.py Outdated

mavysavydav added 2 commits June 2, 2021 10:17

Renamed variables for clarity and added clarifying comments

79e1c72

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

changed file name from inference_helpers.py to inference.py

6dc6104

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>

feast-ci-bot assigned woop Jun 2, 2021

feast-ci-bot added the lgtm label Jun 2, 2021

woop approved these changes Jun 2, 2021

View reviewed changes

feast-ci-bot added the approved label Jun 2, 2021

feast-ci-bot merged commit 09fe2a6 into feast-dev:master Jun 2, 2021

Uh oh!

Conversation

mavysavydav commented May 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feast-ci-bot commented May 6, 2021

Uh oh!

jklegar commented May 10, 2021

Uh oh!

jklegar commented May 10, 2021

Uh oh!

jklegar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mavysavydav commented May 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mavysavydav commented May 25, 2021

Uh oh!

woop commented May 25, 2021

Uh oh!

mavysavydav commented May 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

woop commented Jun 2, 2021

Uh oh!

feast-ci-bot commented Jun 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mavysavydav commented May 6, 2021 •

edited

Loading

codecov-commenter commented May 25, 2021 •

edited

Loading