Skip to content

Fix failing tests - #1450

Merged
pyalex merged 5 commits into
feast-dev:v0.9-branchfrom
terryyylim:ignore-protos-flake8
Apr 9, 2021
Merged

Fix failing tests#1450
pyalex merged 5 commits into
feast-dev:v0.9-branchfrom
terryyylim:ignore-protos-flake8

Conversation

@terryyylim

@terryyylim terryyylim commented Apr 9, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Terence Lim terencelimxp@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

@terryyylim
Ignore protos for flake8 check
7273da8 
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
@feast-ci-bot

feast-ci-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

@terryyylim: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot

feast-ci-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: terryyylim
To complete the pull request process, please assign davidheryanto after the PR has been reviewed.
You can assign the PR to them by writing /assign @davidheryanto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terryyylim
Install missing dependencies
2990877 
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
@terryyylim
Bump testcontainers version
c69de3e 
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
@terryyylim
Update kubectl version
85d556f 
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
@terryyylim
Revert kubectl version
80fb7a0 
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
@terryyylim terryyylim changed the title Ignore protos for flake8 check Fix failing tests Apr 9, 2021
@pyalex
pyalex merged commit 00c8f63 into feast-dev:v0.9-branch Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto davidheryanto is a code owner
@khorshuheng khorshuheng Awaiting requested review from khorshuheng khorshuheng is a code owner
@pyalex pyalex Awaiting requested review from pyalex pyalex is a code owner
@woop woop Awaiting requested review from woop woop is a code owner
@zhilingc zhilingc Awaiting requested review from zhilingc zhilingc is a code owner

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed needs-kind size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terryyylim @feast-ci-bot @pyalex