Skip to content

Fixed old urls in documentation - #1406

Merged
woop merged 1 commit into
feast-dev:masterfrom
tedhtchang:fix-urls
Mar 23, 2021
Merged

Fixed old urls in documentation#1406
woop merged 1 commit into
feast-dev:masterfrom
tedhtchang:fix-urls

Conversation

@tedhtchang

@tedhtchang tedhtchang commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Fixed old urls that no longer work.

Which issue(s) this PR fixes:
NONE

Does this PR introduce a user-facing change?:
NONE

@tedhtchang
fixed old urls
29b5583 
Signed-off-by: ted chang <htchang@us.ibm.com>
@tedhtchang
tedhtchang requested review from jklegar and woop as code owners March 23, 2021 06:53
@feast-ci-bot

feast-ci-bot commented Mar 23, 2021

Copy link
Copy Markdown
Collaborator

@tedhtchang: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot

feast-ci-bot commented Mar 23, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedhtchang
To complete the pull request process, please assign jklegar after the PR has been reviewed.
You can assign the PR to them by writing /assign @jklegar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

feast-ci-bot commented Mar 23, 2021

Copy link
Copy Markdown
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop woop changed the title fixed old urls Fixed old urls in documentation Mar 23, 2021
@woop

woop commented Mar 23, 2021

Copy link
Copy Markdown
Member

Thanks @tedhtchang

@woop
woop merged commit dc48008 into feast-dev:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklegar jklegar Awaiting requested review from jklegar
@woop woop Awaiting requested review from woop

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed needs-kind needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tedhtchang @feast-ci-bot @woop