Skip to content

Fix documentation building for Feast SDK - #1400

Merged
woop merged 12 commits into
feast-dev:masterfrom
woop:fix-python-doc-building
Mar 21, 2021
Merged

Fix documentation building for Feast SDK#1400
woop merged 12 commits into
feast-dev:masterfrom
woop:fix-python-doc-building

Conversation

@woop

@woop woop commented Mar 21, 2021

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Current documentation building (using Netflify) is out of date and doesn't support versioning. The introduced changes will make it possible for us to use https://readthedocs.org/.

Does this PR introduce a user-facing change?:

None

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

woop added 3 commits March 20, 2021 18:42
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
@woop
woop force-pushed the fix-python-doc-building branch from 384b0cd to d1d7cf5 Compare March 21, 2021 01:51
@woop
woop force-pushed the fix-python-doc-building branch from d1d7cf5 to 2e57db6 Compare March 21, 2021 01:52
Signed-off-by: Willem Pienaar <git@willem.co>
woop added 8 commits March 20, 2021 18:57
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
@woop
woop merged commit beb30b7 into feast-dev:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants