Python-centric feast deploy CLI - #1362
Conversation
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
| local: Optional[LocalOnlineStoreConfig] = None | ||
|
|
||
|
|
||
| class RepoConfig(NamedTuple): |
There was a problem hiding this comment.
What if we just called this Config?
There was a problem hiding this comment.
I think we already have a Config or two so I wanted to be a bit more specific here
There was a problem hiding this comment.
We should reconcile https://github.com/feast-dev/feast/blob/master/sdk/python/feast/feature_store_config.py and this since I think they're the same thing
|
/kind feature |
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
|
I also think that we should be adding docs as part of this PR, even though I have't had time to scaffold a location for the documentation as part of docs.feast.dev. Would it make sense to have some minimal documentation in a .md file? Or do you think we have to wait for docs.feast.dev to be ready? |
It is not that I want to wait but i have more followup PRs for reading and writing on top of this, so I'd rather merge this quickly and add docs separately |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Signed-off-by: Oleg Avdeev oleg.v.avdeev@gmail.com
What this PR does / why we need it:
Add
feast applyandfeast-teardowncommands, supporting new feature repo functionality and GCP Firestore as an online feature store.Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: