Skip to content

Move java components to feast-java repo#1316

Merged
jklegar merged 11 commits into
feast-dev:masterfrom
jklegar:jacob_move_java
Feb 15, 2021
Merged

Move java components to feast-java repo#1316
jklegar merged 11 commits into
feast-dev:masterfrom
jklegar:jacob_move_java

Conversation

@jklegar
Copy link
Copy Markdown
Collaborator

@jklegar jklegar commented Feb 5, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Java components moved into a separate repository `feast-java`

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Feb 5, 2021

@jklegar: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end 0a345f5e8668c9655e5d6fd4a8edc47d0fb84bee link /test test-end-to-end
test-end-to-end-gcp 0a345f5e8668c9655e5d6fd4a8edc47d0fb84bee link /test test-end-to-end-gcp
test-end-to-end-aws 0a345f5e8668c9655e5d6fd4a8edc47d0fb84bee link /test test-end-to-end-aws
test-end-to-end-sparkop 0a345f5e8668c9655e5d6fd4a8edc47d0fb84bee link /test test-end-to-end-sparkop
test-end-to-end-azure 0a345f5e8668c9655e5d6fd4a8edc47d0fb84bee link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jklegar
remove java code and modify pom.xml
6b3cdbf 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
move core and serving docker files
47839f1 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
move one github action
597148a 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
move unit-test-java
d4b7d95 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
move integration-test action
24145ac 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
remove datatypes/java, pom.xml, java make commands
fbb9257 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
move building docker images to feast-java
56b98b7 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
move java release jobs to feast-java repo
68a0a3b 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
remove lint-versions
77067d4 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
don't build-push-docker-images for core and serving
e3e538f 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@woop
Copy link
Copy Markdown
Member

woop commented Feb 12, 2021

@jklegar you can remove m2 caching here https://github.com/feast-dev/feast/blob/e3e538fabb3638176ade34ffb769868fe947309e/.github/workflows/complete.yml

@woop
Copy link
Copy Markdown
Member

woop commented Feb 12, 2021

And here https://github.com/feast-dev/feast/blob/e3e538fabb3638176ade34ffb769868fe947309e/.github/workflows/master_only.yml

@woop
Copy link
Copy Markdown
Member

woop commented Feb 12, 2021

There are still some core/serving parts in the makefile

feast/Makefile

Line 89 in e3e538f

@$(MAKE) push-core-docker registry=$(REGISTRY) version=$(VERSION)

@woop
Copy link
Copy Markdown
Member

woop commented Feb 12, 2021

Is the CI dockerfile still used? Do we need the maven related steps?

@woop
Copy link
Copy Markdown
Member

woop commented Feb 12, 2021

I think https://github.com/feast-dev/feast/blob/e3e538fabb3638176ade34ffb769868fe947309e/.scalafmt.conf can be removed as well.

@jklegar
more cleanup per comments
05e35bb 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
Copy link
Copy Markdown
Collaborator Author

jklegar commented Feb 12, 2021

Is the CI dockerfile still used? Do we need the maven related steps?

it's used in feast-spark, so we may want to transfer it to there

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Feb 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Feb 13, 2021

/lgtm

@jklegar jklegar merged commit b1f2ceb into feast-dev:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels

approved kind/housekeeping lgtm release-note size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jklegar @feast-ci-bot @woop