Online serving optimizations - #1286
Merged
Merged
Conversation
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
January 25, 2021 07:47
pyalex
force-pushed
the
fix-serving-latency
branch
from
January 25, 2021 09:47
917721e to
fb5976e
Compare
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
force-pushed
the
fix-serving-latency
branch
2 times, most recently
from
January 27, 2021 02:08
2430b88 to
5c65f4a
Compare
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
force-pushed
the
fix-serving-latency
branch
from
January 28, 2021 02:17
5c65f4a to
b595f0d
Compare
khorshuheng
reviewed
Jan 28, 2021
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Collaborator
Author
|
/test test-end-to-end-gcp |
1 similar comment
Collaborator
Author
|
/test test-end-to-end-gcp |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com
What this PR does / why we need it:
Some performance concerns about
OnlineServingServiceV2were addressed in this PR:specsretrieving out of nested for loops - prepare required data in advance.OnlineRetrieverV2interface - get rid ofOptionalWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: