Skip to content

Azure example terraform#1274

Merged
jklegar merged 6 commits intofeast-dev:masterfrom
jklegar:jacob_azure_tf
Jan 27, 2021
Merged

Azure example terraform#1274
jklegar merged 6 commits intofeast-dev:masterfrom
jklegar:jacob_azure_tf

Conversation

@jklegar
Copy link
Copy Markdown
Collaborator

@jklegar jklegar commented Jan 19, 2021

What this PR does / why we need it: An example terraform configuration to run Feast on Azure

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@jklegar
Copy link
Copy Markdown
Collaborator Author

jklegar commented Jan 20, 2021

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Jan 20, 2021
woop
woop reviewed Jan 26, 2021
View reviewed changes
Comment thread infra/terraform/azure/README.md Outdated
Copy link
Copy Markdown
Member

@woop woop Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, is there a reason we are using HDInsights over Event Hubs for Kafka?

Copy link
Copy Markdown
Collaborator Author

@jklegar jklegar Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HDInsight actually runs Kafka (it's essentially Kafka managed by Azure), whereas Event Hubs is Kafka-client-compatible but doesn't support certain Kafka features. Seemed faster and more likely to work using HDInsight

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jan 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Jan 26, 2021

/lgtm

@jklegar
example terraform for azure
0eeaa65 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
azure tf adjustments
b21302b 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
more adjustments
3717711 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
changes to example notebook
f7a2ce9 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
add default aks namespace
f438086 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
remove extra print statement
5e93fbb 
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jan 27, 2021

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 27, 2021
@jklegar jklegar merged commit 057424b into feast-dev:master Jan 27, 2021
@jklegar jklegar deleted the jacob_azure_tf branch February 4, 2021 23:57
@jklegar jklegar mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels

approved kind/feature New feature or request release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jklegar @feast-ci-bot @woop