allow https url for spark ingestion jar - #1266
Merged
Merged
Conversation
jklegar
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
January 14, 2021 22:59
Member
|
@jklegar so this change doesn't apply to dataproc? |
Collaborator
Author
|
I believe on dataproc https should already work due to |
Collaborator
|
/retest |
Collaborator
|
/test test-end-to-end-aws |
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
jklegar
force-pushed
the
jacob_https_jar
branch
from
January 18, 2021 16:44
c2085f4 to
dead34c
Compare
Collaborator
Author
|
/test test-end-to-end-aws |
oavdeev
approved these changes
Jan 18, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jklegar, oavdeev The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacob Klegar jacob@tecton.ai
What this PR does / why we need it: previously if the spark ingestion jar was a https url (which is the default), ingestion would fail because Feast would try to read and upload the jar as if the url were a local path
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: