Skip to content

fix historical test for azure - #1262

Merged
jklegar merged 4 commits into
feast-dev:masterfrom
jklegar:jacob_fix_hist
Jan 8, 2021
Merged

fix historical test for azure#1262
jklegar merged 4 commits into
feast-dev:masterfrom
jklegar:jacob_fix_hist

Conversation

@jklegar

@jklegar jklegar commented Jan 8, 2021

Copy link
Copy Markdown
Collaborator

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: fixes the historical test to support azure blob storage

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@woop

woop commented Jan 8, 2021

Copy link
Copy Markdown
Member

/lgtm

Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jklegar, oavdeev
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar
jklegar merged commit d8a3795 into feast-dev:master Jan 8, 2021
@jklegar
jklegar deleted the jacob_fix_hist branch February 4, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants